Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
MIME-Version: 1.0
In-Reply-To: <491651A7-34C3-4A7F-B8FD-26A54F39DF7D@honton.org>
References: <git-pr-96-commons-lang@git.apache.org>
	<491651A7-34C3-4A7F-B8FD-26A54F39DF7D@honton.org>
Date: Fri, 12 Jun 2015 12:55:27 +0100
Message-ID: 
 <CAOGo0VYwPOQ_sStniu1TX8K1h_75zNRc_okZPprJF+faaNwo=Q@mail.gmail.com>
Subject: Re: [Lang] commons-lang pull request: refactor FastDateParser
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=UTF-8

Could you create a JIRA issue with a link to the request please?

See https://github.com/apache/commons-lang/blob/master/CONTRIBUTING.md

It's much easier to keep track of the progress of a patch this way.

Thanks!


On 12 June 2015 at 04:52, Chas Honton <chas@honton.org> wrote:
> I just created a pull request for a major refactor of the FastDateParser class. I request anyone with org.apache.commons.lang3.time interest and/or experience take time to review.
>
> Thanks,
> Chas
>
> Begin forwarded message:
>
>> From: chonton <git@git.apache.org>
>> Date: June 11, 2015 at 8:19:46 PM PDT
>> To: issues@commons.apache.org
>> Subject: [GitHub] commons-lang pull request: refactor FastDateParser
>> Reply-To: issues@commons.apache.org
>> Reply-To: issues@commons.apache.org
>>
>> GitHub user chonton opened a pull request:
>>
>>    https://github.com/apache/commons-lang/pull/96
>>
>>    refactor FastDateParser
>>
>>    use hashmap for performance
>>        break down regular expressions to per-format, allowing
>>    ParsePosition to get set
>>        add parse with Calendar input, allowing client to set leniency
>>    and/or replace display names
>>
>> You can merge this pull request into a Git repository by running:
>>
>>    $ git pull https://github.com/chonton/commons-lang refactor-fastdateparser
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>>    https://github.com/apache/commons-lang/pull/96.patch
>>
>> To close this pull request, make a commit to your master/trunk branch
>> with (at least) the following in the commit message:
>>
>>    This closes #96
>>
>> ----
>> commit 94faa31bcf5c4fcb20818a3a0d23ae789932d2df
>> Author: Chas Honton <chas@apache.org>
>> Date:   2015-06-12T03:07:13Z
>>
>>    refactor FastDateParser
>>
>>    use hashmap for performance
>>        break down regular expressions to per-format, allowing
>>    ParsePosition to get set
>>        add parse with Calendar input, allowing client to set leniency
>>    and/or replace display names
>>
>> ----
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working, please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org