commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1686747 [1/3] - in /commons/proper/io/trunk/src: main/java/org/apache/commons/io/ main/java/org/apache/commons/io/filefilter/ main/java/org/apache/commons/io/input/ main/java/org/apache/commons/io/monitor/ main/java/org/apache/commons/io/o...
Date Tue, 23 Jun 2015 16:11:27 GMT
On 22 June 2015 at 06:38, Kristian Rosenvold
<kristian.rosenvold@gmail.com> wrote:
> 2015-06-22 2:53 GMT+02:00 sebb <sebbaz@gmail.com>:
>
>> >What was the Findbugs error?
>>
>> Best not to mix these in a single commit.
>>
> Sorry about that.
>
> org.apache.commons.io.output.DeferredFileOutputStream#thresholdReached
> possible file handle leak upon exception
>

Can you update the SVN log message accordingly?

>
>
>>
>> Also looks like many of the checkstyle fixes are just line-wraps; I
>> thought we allowed a longer line length?
>> Screens tend to be used in landscape mode so it's easier to read code
>> if is not wrapped unnecessarily
>>
>
> Most of it is just feeding the OCD. 0 checkstyle errors is the one ring to
> rule them all :)
>
> Would it make sense to change the checkstyle column width to something like
> 160 ?

Or drop the rule entirely?

> Kristian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message