commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kristian Rosenvold <kristian.rosenv...@gmail.com>
Subject Re: svn commit: r1686747 [1/3] - in /commons/proper/io/trunk/src: main/java/org/apache/commons/io/ main/java/org/apache/commons/io/filefilter/ main/java/org/apache/commons/io/input/ main/java/org/apache/commons/io/monitor/ main/java/org/apache/commons/io/o...
Date Tue, 23 Jun 2015 16:44:14 GMT
2015-06-23 18:11 GMT+02:00 sebb <sebbaz@gmail.com>:
>
> > org.apache.commons.io.output.DeferredFileOutputStream#thresholdReached
> > possible file handle leak upon exception
> >
>
> Can you update the SVN log message accordingly?
>
Done


>
> >
> >
> >>
> >> Also looks like many of the checkstyle fixes are just line-wraps; I
> >> thought we allowed a longer line length?
> >> Screens tend to be used in landscape mode so it's easier to read code
> >> if is not wrapped unnecessarily
> >>
> >
> > Most of it is just feeding the OCD. 0 checkstyle errors is the one ring
> to
> > rule them all :)
> >
> > Would it make sense to change the checkstyle column width to something
> like
> > 160 ?
>
> Or drop the rule entirely?
>
> I'm all in favour of anything >120 chars :)

Kristian

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message