commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Caleb Cushing <xenoterrac...@gmail.com>
Subject Re: RandomStringUtils with variable lengths
Date Sun, 28 Jun 2015 07:39:44 GMT
https://github.com/apache/commons-lang/pull/101 created a new pull request
after doing some branch rewrites.

On Mon, Jun 22, 2015 at 1:02 PM Benedikt Ritter <britter@apache.org> wrote:

> Yes, please go ahead!
>
>
> 2015-06-20 2:44 GMT+02:00 Caleb Cushing <xenoterracide@gmail.com>:
>
>> so should I spend the time working this into a more finalized patch, that
>> includes the stuff for numeric and alphanumeric as well? (and fixes the
>> feedback)
>>
>> On Sun, Jun 7, 2015 at 6:23 AM Benedikt Ritter <britter@apache.org>
>> wrote:
>>
>>> Hello Caleb,
>>>
>>> 2015-06-06 21:45 GMT+02:00 Caleb Cushing <xenoterracide@gmail.com>:
>>>
>>>>
>>>>> I'm not sure I understand your proposal. Is this about returning a
>>>>> single random character?
>>>>> It would be good if you could provide a patch with some unit tests.
>>>>> You can use GitHub for contributing [1]
>>>>>
>>>>
>>>> I created a preliminary pull request here
>>>>
>>>> https://github.com/apache/commons-lang/pull/94
>>>>
>>>> (side note: I'm perplexed how I could have affected the test that's
>>>> failing on Java 8)
>>>>
>>>
>>> Thank you, I'll have a look soon.
>>>
>>>
>>>> --
>>>> Caleb Cushing
>>>>
>>>
>>>
>>>
>>> --
>>> http://people.apache.org/~britter/
>>> http://www.systemoutprintln.de/
>>> http://twitter.com/BenediktRitter
>>> http://github.com/britter
>>>
>> --
>> Caleb Cushing
>>
>> http://xenoterracide.com
>>
>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>
-- 
Caleb Cushing

http://xenoterracide.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message