Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Date: Sat, 23 May 2015 03:10:33 +0000 (UTC)
From: "Bruno P. Kinoshita" <brunodepaulak@yahoo.com.br>
Reply-To: "Bruno P. Kinoshita" <brunodepaulak@yahoo.com.br>
To: Commons Developers List <dev@commons.apache.org>
Message-ID: <1173353411.383916.1432350633804.JavaMail.yahoo@mail.yahoo.com>
In-Reply-To: <555F508F.30802@gmail.com>
References: <555F508F.30802@gmail.com>
Subject: Re: [VOTE] Release pool 2.4 based on RC1
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_383915_253495037.1432350633799"

------=_Part_383915_253495037.1432350633799
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Build works fine in=20

Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-15T06=
:29:23+13:00)
Maven home: /opt/apache-maven-3.2.5
Java version: 1.8.0_45, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.16.0-38-generic", arch: "amd64", family: "uni=
x"
Rat reports 1 binary, against 2 binaries from the previous web site. I thin=
k it is because the previous version included site.tgz in the report. One n=
ew error in checkstyle, but that doesn't seem relevant.
This version introduces five errors in FindBugs, all related to the same ty=
pe [1]=20

I've changed locally a part of the code reported by FindBugs (GenericKeyedO=
bjectPool L755). From
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for (K k : poolMap.keySet()) {
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ObjectDe=
que<T> queue =3D poolMap.get(k);
To

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for (Map.Entry<K, ObjectDeque<T>=
> entry : poolMap.entrySet()) {
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ObjectDe=
que<T> queue =3D entry.getValue();
Running the build again, all tests pass and the FindBugs error is gone. But=
 I'm not sure if it wasn't intentional to avoid stale reads from the map.
Could anyone confirm if the errors reported by FindBugs can be ignored, ple=
ase?
Thanks!Bruno

http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR

=20
      From: Phil Steitz <phil.steitz@gmail.com>
 To: Commons Developers List <dev@commons.apache.org>=20
 Sent: Saturday, May 23, 2015 3:51 AM
 Subject: [VOTE] Release pool 2.4 based on RC1
  =20
This is a vote to release version 2.4 of Apache Commons Pool based
on RC1.

Here is the release candidate:
https://dist.apache.org/repos/dist/dev/commons/pool/
(r9083)

Built from:
https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/
(r1680963)

Release notes:
https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt

Maven artifacts:
http://s.apache.org/Va6

site:
http://people.apache.org/~psteitz/pool/pool-2.4-rc1

keys:

https://www.apache.org/dist/commons/KEYS

Votes, please.

This vote will close no sooner that 72 hours from now (15:50 GMT
25-May-2015).

=C2=A0 [ ] +1 Release these artifacts
=C2=A0 [ ] +0 OK, but...
=C2=A0 [ ] -0 OK, but really should fix...
=C2=A0 [ ] -1 I oppose this release because...

Thanks!

Phil


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


  =20

------=_Part_383915_253495037.1432350633799--