Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 001F717690 for ; Mon, 20 Apr 2015 03:54:32 +0000 (UTC) Received: (qmail 28958 invoked by uid 500); 20 Apr 2015 03:54:32 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 28818 invoked by uid 500); 20 Apr 2015 03:54:32 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 28806 invoked by uid 99); 20 Apr 2015 03:54:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Apr 2015 03:54:32 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: message received from 54.76.25.247 which is an MX secondary for dev@commons.apache.org) Received: from [54.76.25.247] (HELO mx1-eu-west.apache.org) (54.76.25.247) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Apr 2015 03:54:06 +0000 Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 8B56F25064 for ; Mon, 20 Apr 2015 03:54:05 +0000 (UTC) Received: by wgyo15 with SMTP id o15so165142695wgy.2 for ; Sun, 19 Apr 2015 20:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=bOmtigTa9cVELWgQJrq3tX6ktvATq1nJw+c3NA/rUtw=; b=jiNrBsboxeKQ568B+J404X7wHF+KBqhzfSfc6OVX08k2u5PDTbYWFIqF37vGVcAWo3 kT/l2MKikiTMTncUt0Txlfu2KSNjDyAxsWH3tLiPN8PtCnFU4rvtAvXotmOzpLUg/jVL 1sMoQgR426xC54VYmkQyYBDT5OTToSu6UDFaT7wIwjLpOCIImR0A/xF0uxqawijgiQ2l Oo7sgs2xG5XPv4EGZe6xRDITuk4qKynGTm4sxsC9U0mlPuMfGhPWc2PJK8jgbeGTGacU fiLyjxOdQ1o1VTYXUD7ytMDbyhC38Qr8umqc1yGoklAM07DaGhNtjVw21sRHZiGXpTPr 4Yaw== MIME-Version: 1.0 X-Received: by 10.180.103.231 with SMTP id fz7mr21198173wib.35.1429502000067; Sun, 19 Apr 2015 20:53:20 -0700 (PDT) Received: by 10.27.83.211 with HTTP; Sun, 19 Apr 2015 20:53:20 -0700 (PDT) In-Reply-To: <20150420041037.00000eb1.ecki@zusammenkunft.net> References: <20150420002555.A9A9EAC01D9@hades.apache.org> <20150420030531.00002c86.ecki@zusammenkunft.net> <20150420041037.00000eb1.ecki@zusammenkunft.net> Date: Sun, 19 Apr 2015 20:53:20 -0700 Message-ID: Subject: Re: svn commit: r1674710 - /commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/CloseShieldOutputStream.java From: Gary Gregory To: Commons Developers List Content-Type: multipart/alternative; boundary=f46d04182822eb773f05141fde98 X-Virus-Checked: Checked by ClamAV on apache.org --f46d04182822eb773f05141fde98 Content-Type: text/plain; charset=UTF-8 Javadoc 8 does not allow for XHTML tags to not be closed (in the default mode). When I run 'mvn clean site', I get, more of these errors and others: 9 errors 6 warnings [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 07:16 min [INFO] Finished at: 2015-04-19T20:33:23-07:00 [INFO] Final Memory: 57M/386M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on project commons-io: Error during page generation: Error rendering Maven report: [ERROR] Exit code: 1 - C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\CopyUtils.java:309: warning: no @param for encoding [ERROR] public static void copy( [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\CopyUtils.java:358: warning: no @param for encoding [ERROR] public static void copy( [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\FileCleaner.java:140: error: reference not found [ERROR] * {@link javax.servlet.ServletContextListener#contextDestroyed(javax.servlet.ServletContextEvent)}. [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\FileCleaner.java:33: error: reference not found [ERROR] * {@link javax.servlet.ServletContextListener#contextDestroyed(javax.servlet.ServletContextEvent)} or similar. [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\FileCleaningTracker.java:186: error: reference not found [ERROR] * {@link javax.servlet.ServletContextListener#contextDestroyed(javax.servlet.ServletContextEvent)}. [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\FileCleaningTracker.java:40: error: reference not found [ERROR] * {@link javax.servlet.ServletContextListener#contextDestroyed} or similar. [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\IOUtils.java:3069: warning: no @return [ERROR] public static byte[] readFully(final InputStream input, final int length) throws IOException { [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\input\BoundedReader.java:66: warning: no description for @throws [ERROR] * @throws IOException [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\input\BoundedReader.java:76: warning: no description for @throws [ERROR] * @throws IOException [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\input\BoundedReader.java:130: warning: no description for @throws [ERROR] * @throws IOException [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\input\BoundedReader.java:28: error: self-closing element not allowed [ERROR] *

[ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\input\UnixLineEndingInputStream.java:60: error: incorrect use of inline tag [ERROR] * @inheritDoc [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\input\UnixLineEndingInputStream.java:102: error: incorrect use of inline tag [ERROR] * @inheritDoc [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\input\WindowsLineEndingInputStream.java:62: error: incorrect use of inline tag [ERROR] * @inheritDoc [ERROR] ^ [ERROR] C:\vcs\svn\apache\commons\trunks-proper\io\src\main\java\org\apache\commons\io\input\WindowsLineEndingInputStream.java:115: error: incorrect use of inline tag [ERROR] * @inheritDoc [ERROR] ^ [ERROR] [ERROR] Command line was: "C:\Program Files\Java\jdk1.8.0_45\jre\..\bin\javadoc.exe" @options @packages [ERROR] [ERROR] Refer to the generated Javadoc files in 'C:\vcs\svn\apache\commons\trunks-proper\io\target\site\apidocs' dir. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException Using: Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c; 2015-03-13T13:10:27-07:00) Maven home: C:\Java\apache-maven-3.3.1 Java version: 1.8.0_45, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.8.0_45\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos" Gary On Sun, Apr 19, 2015 at 7:10 PM, Bernd Eckenfels wrote: > Hello, > > commons-io has multiple Java 8 doclint warnings and errors > (mostly missing references and self closing

and @inheritDoc) in > the current revision, but "CloseShieldOutputStream without the > closing

tag is not in that list. What command did > you run and what error it is reporting? I tried javadoc:javadoc. > > Gruss > Bernd > > Am Sun, 19 Apr 2015 18:35:13 -0700 > schrieb Gary Gregory : > > > On Sun, Apr 19, 2015 at 6:05 PM, Bernd Eckenfels > > wrote: > > > > > Hello, > > > > > > Am Mon, 20 Apr 2015 00:25:55 -0000 > > > schrieb ggregory@apache.org: > > > > > > > > commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/CloseShieldOutputStream.java > > > > (original) +++ > > > > > > > > commons/proper/io/trunk/src/main/java/org/apache/commons/io/output/CloseShieldOutputStream.java > > > > Mon Apr 20 00:25:55 2015 @@ -24,7 +24,7 @@ import > > > > java.io.OutputStream; > > > > * This class is typically used in cases where an output stream > > > > needs to be > > > > * passed to a component that wants to explicitly close the > > > > stream even if > > > > * other components would still use the stream for output. > > > > - * > > > > + *

> > > > * @version $Id$ > > > > * @since 1.4 > > > > */ > > > > > > Uhm... is that really an improvement? If you use html tags (like it > > > is specified by javadoc) you dont need ending tags. > > > > > > > Try building with Java 8 and see what happens... ;-) > > > > Gary > > > > > > > > Gruss > > > Bernd > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > > > For additional commands, e-mail: dev-help@commons.apache.org > > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > > -- E-Mail: garydgregory@gmail.com | ggregory@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Action Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory --f46d04182822eb773f05141fde98--