Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: error (nike.apache.org: local policy)
MIME-Version: 1.0
Date: Sat, 11 Apr 2015 08:02:01 +0100
Message-ID: 
 <CABeJX=3NKtTK72bJjbtcH8Fp8ZQcS4VoNQgO6MzQ5PK3Qt0Ywg@mail.gmail.com>
Subject: [lang] testTimeZoneStrategyPattern() runs twice for no apparent gain
From: Duncan Jones <duncan@wortharead.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=UTF-8

Hi everyone,

Lang takes a few minutes to build on my system, so I was examining
execution times of tests to see if anything can be improved.

I noticed that FastDateParserTest.testTimeZoneStrategyPattern() takes
quite a long time to execute (over 40 seconds for me). Then I noticed
this is executed twice, once for FastDateParserTest and once for the
subclass FastDateFormat_ParserTest. Yet the method doesn't appear to
use the result of getInstance(). As a result, we don't want this being
executed by subclasses as it gains us nothing.

Before I refactor this test, possibly into a separate
TimeZoneStrategyTest class, can anyone suggest a reason not to? Or a
better solution / location for the test?

Duncan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org