commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacktan1991 <...@git.apache.org>
Subject [GitHub] commons-lang pull request: fix JsonToStringStyle
Date Mon, 20 Apr 2015 09:00:25 GMT
GitHub user jacktan1991 opened a pull request:

    https://github.com/apache/commons-lang/pull/66

    fix JsonToStringStyle

    except number types and boolean type , all other types in java (char, String, Date etc.)
should be `appendAsString`. 
    + add method `appendDetail(StringBuffer buffer, String fieldName, char value)` to `JsonToStringStyle`
    + modify `appendDetail(StringBuffer buffer, String fieldName, Object value)`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jacktan1991/commons-lang branch-3.4-fix-json-style

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #66
    
----
commit fc5fbc70f76e2e028435d145ea8d91dd10fe5daa
Author: Jack <792626757@qq.com>
Date:   2015-04-20T08:22:28Z

    add testChar and testDate Cases into JsonToStringStyleTest

commit ed0fea128ad83d6c07367eea7bf2e24116fa5723
Author: Jack <792626757@qq.com>
Date:   2015-04-20T08:34:59Z

    fix the JsonToStringStyle:except number types and boolean type , all other types in java
(char, String, Date etc.) should be 'appendAsString'

commit d2195f07a714b3e332d7c8feaf787858cc937023
Author: Jack <jacktan1991@users.noreply.github.com>
Date:   2015-04-20T08:48:42Z

    Merge pull request #1 from jackiewhu/branch-3.4-fix-json-style
    
    Branch 3.4 fix json style

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message