commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: [LANG] Coveralls threshold
Date Wed, 15 Apr 2015 14:06:23 GMT
Hello Phil,

2015-04-15 14:44 GMT+02:00 Phil Steitz <phil.steitz@gmail.com>:

> Whatever discussions have impact on the code should come to this list.
> Please make sure that any discussion of patches at least gets echoed to
> this list.


Yes, I need to take care of this. I need some spare time to put together a
request for infra to mirror all comments to issues@


> Regarding your question, I have never seen much value in the kind of nag
> you are referring to.  Just my 2c.
>

Okay, so you would deactivate the coveralls check completely?

Benedikt


>
>
>
> > On Apr 15, 2015, at 5:47 AM, Benedikt Ritter <britter@apache.org> wrote:
> >
> > Hi all,
> >
> > when using coveralls [1] one need to configure a test coverage threshold.
> > If a PR lowers the test coverage below this threshold, coveralls will
> send
> > a notification. This happened for PR 63 [2].
> > I'm about to create an issue for infra for configuring the threshold. But
> > I'm not sure what would be a reasonable value. I'm thinking about max. 3%
> > drop of the overall coverage and a lower bound of 90%.
> >
> > Thoughts?
> >
> > Benedikt
> >
> > [1] https://coveralls.io
> > [2] https://github.com/apache/commons-lang/pull/63
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message