commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chas Honton <c...@honton.org>
Subject Re: [lang] testTimeZoneStrategyPattern() runs twice for no apparent gain
Date Sat, 11 Apr 2015 15:32:15 GMT
Duncan,

Nothing lost by moving into separate test class. Speed gained. 

Chas

> On Apr 11, 2015, at 12:02 AM, Duncan Jones <duncan@wortharead.com> wrote:
> 
> Hi everyone,
> 
> Lang takes a few minutes to build on my system, so I was examining
> execution times of tests to see if anything can be improved.
> 
> I noticed that FastDateParserTest.testTimeZoneStrategyPattern() takes
> quite a long time to execute (over 40 seconds for me). Then I noticed
> this is executed twice, once for FastDateParserTest and once for the
> subclass FastDateFormat_ParserTest. Yet the method doesn't appear to
> use the result of getInstance(). As a result, we don't want this being
> executed by subclasses as it gains us nothing.
> 
> Before I refactor this test, possibly into a separate
> TimeZoneStrategyTest class, can anyone suggest a reason not to? Or a
> better solution / location for the test?
> 
> Duncan
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message