Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Message-ID: <54E25D73.7080400@apache.org>
Date: Mon, 16 Feb 2015 21:13:23 +0000
From: Mark Thomas <markt@apache.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Commons Developers List <dev@commons.apache.org>
Subject: Re: [DBCP] tomcat / JNDI users - pls review DBCP-435 changes
References: <54E252F9.2020807@gmail.com>
In-Reply-To: <54E252F9.2020807@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 16/02/2015 20:28, Phil Steitz wrote:
> I think the idea in this issue / patch is good - warn users when
> they are specifying obsolete or unknown properties in JNDI references.
> 
> I tested with tc 8 trunk and apart from the formatting changes I put
> into the patch (and suppressed redundant stderr writes), output
> looks similar to what is in the ticket.  What I don't know is what
> other "unknown" properties might best be added to the "silent" list
> or other reasons that tc admins might find this annoying.  Thanks in
> advance for review / feedback.

Looks OK to me.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org