Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2021817BFE for ; Mon, 2 Feb 2015 21:47:57 +0000 (UTC) Received: (qmail 27529 invoked by uid 500); 2 Feb 2015 21:47:57 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 27392 invoked by uid 500); 2 Feb 2015 21:47:57 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 27381 invoked by uid 99); 2 Feb 2015 21:47:57 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Feb 2015 21:47:57 +0000 Received: from [192.168.23.9] (host86-191-218-51.range86-191.btcentralplus.com [86.191.218.51]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 228571A012A for ; Mon, 2 Feb 2015 21:47:56 +0000 (UTC) Message-ID: <54CFF07E.7090104@apache.org> Date: Mon, 02 Feb 2015 21:47:42 +0000 From: Mark Thomas User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Commons Developers List Subject: Re: [DBCP] Getting ready to roll 2.1 References: <54CD350A.2020903@gmail.com> In-Reply-To: <54CD350A.2020903@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 31/01/2015 20:03, Phil Steitz wrote: > I am about ready (at last) to start rolling RCs for DBCP 2.1. I > just opened an issue [1] that I am on the fence about and would like > feedback on. I am not sure, actually, that it is an improvement to > force initial requests to queue waiting for the pool to be > pre-filled (what the patch now does). There is a small chance that > with the current code, a client can get a DS with null logWriter, > but it is immediately set thereafter. I am happy to close [1] as > INVALID if others agree that current behavior is better. > > Review and feedback on [2] would also be appreciated. I skim read the patch. I wonder about the portability / usefulness of the default values for the disconnection codes but a) I don't have a better set to suggest right now and b) they are configurable anyway so no objections from me. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org