commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Bourg <ebo...@apache.org>
Subject Re: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1
Date Wed, 18 Feb 2015 13:30:58 GMT
> [X] +1 Release these artifacts

Tested with OpenJDK 7 on Debian.

The name of the isLogExpiredConnections() method in BasicDataSource and
BasicDataSourceMXBean looks a bit inconsistent with the other methods
returning a boolean. I would have picked getLogExpiredConnections
(similar to the getRemove*, getTest* and getLogAbandoned methods) or
isExpiredConnectionsLogged (similar to
isAccessToUnderlyingConnectionAllowed) instead.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message