commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: [DBCP] Getting ready to roll 2.1
Date Mon, 02 Feb 2015 21:47:42 GMT
On 31/01/2015 20:03, Phil Steitz wrote:
> I am about ready (at last) to start rolling RCs for DBCP 2.1.  I
> just opened an issue [1] that I am on the fence about and would like
> feedback on.  I am not sure, actually, that it is an improvement to
> force initial requests to queue waiting for the pool to be
> pre-filled (what the patch now does).  There is a small chance that
> with the current code, a client can get a DS with null logWriter,
> but it is immediately set thereafter. I am happy to close [1] as
> INVALID if others agree that current behavior is better.
> 
> Review and feedback on [2] would also be appreciated.

I skim read the patch. I wonder about the portability / usefulness of
the default values for the disconnection codes but a) I don't have a
better set to suggest right now and b) they are configurable anyway so
no objections from me.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message