commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j--baker <...@git.apache.org>
Subject [GitHub] commons-lang pull request: Lang 1081 - DiffBuilder left.equals(rig...
Date Sun, 18 Jan 2015 15:56:11 GMT
GitHub user j--baker opened a pull request:

    https://github.com/apache/commons-lang/pull/41

    Lang 1081 - DiffBuilder left.equals(right)

    Please see: https://issues.apache.org/jira/browse/LANG-1081
    
    Two parts:
    1) Added two (T) casts to get my old JDK to work during the Maven tests.
    2) Added fix to DiffBuilder and updated the JUnit test.  A left.equals(right) (or vice
versa) test is now done.
    
    Thank you for your time.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/j--baker/commons-lang LANG-1081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
    
----
commit 6397e87322fc22e42cb3095959e8069a3737ccb8
Author: j--baker <j--baker@users.noreply.github.com>
Date:   2015-01-18T15:39:43Z

    Add casts to T to avoid compiler errors.

commit 0c2eacc8f11e8bf92be41b8187bd01cbe200ef8d
Author: j--baker <j--baker@users.noreply.github.com>
Date:   2015-01-18T15:41:08Z

    LANG-1081:
    - Update DiffBuilder.append(String, Object, Object) so that a left.equals(right) (or vice
versa) test is made after determining that left != right and that they are not arrays.
    - Update DiffBuilderTest.testObjectsEqual() to test that non-identical but equal instances
will not cause a Diff to be created.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message