commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1650787 - /commons/proper/validator/trunk/pom.xml
Date Fri, 23 Jan 2015 02:24:28 GMT
On 10 January 2015 at 18:17,  <britter@apache.org> wrote:
> Author: britter
> Date: Sat Jan 10 18:17:54 2015
> New Revision: 1650787
>
> URL: http://svn.apache.org/r1650787
> Log:
> Add missing build properties (according to release guide)
>
> Modified:
>     commons/proper/validator/trunk/pom.xml
>
> Modified: commons/proper/validator/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/pom.xml?rev=1650787&r1=1650786&r2=1650787&view=diff
> ==============================================================================
> --- commons/proper/validator/trunk/pom.xml (original)
> +++ commons/proper/validator/trunk/pom.xml Sat Jan 10 18:17:54 2015
> @@ -138,8 +138,6 @@
>    </distributionManagement>
>
>    <properties>
> -    <maven.compiler.source>1.4</maven.compiler.source>
> -    <maven.compiler.target>1.4</maven.compiler.target>
>      <commons.componentid>validator</commons.componentid>
>      <commons.release.version>1.4.1</commons.release.version>
>      <commons.rc.version>RC3</commons.rc.version>
> @@ -153,6 +151,11 @@
>
>      <commons.scmPubCheckoutDirectory>site-content</commons.scmPubCheckoutDirectory>
>      <commons.scmPubUrl>https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-validator</commons.scmPubUrl>
> +
> +    <maven.compiler.source>1.4</maven.compiler.source>
> +    <maven.compiler.target>1.4</maven.compiler.target>
> +    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> +    <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

I think the guide may be outdated here.

CP defines the properties as follows:

    <commons.encoding>iso-8859-1</commons.encoding> -- used for
compiler, javadoc
    <commons.docEncoding>${commons.encoding}</commons.docEncoding> --
javadoc output encoding
    <!-- Define encoding for filtering -->
    <project.build.sourceEncoding>${commons.encoding}</project.build.sourceEncoding>
-- used by plugins as the default
    <project.reporting.outputEncoding>${commons.encoding}</project.reporting.outputEncoding>
-- used by reporting plugins as the default

So components only need to define commons.encoding unless multiple
ones are needed.

I'm not quite sure why there are both commons and project props;
perhaps the commons ones predate the project ones.


>    </properties>
>
>    <build>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message