commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))
Date Tue, 13 Jan 2015 22:11:24 GMT
On 13 January 2015 at 22:02, sebb <sebbaz@gmail.com> wrote:
> Rats! Looks like a bug here:
>
> final String authorityASCII = DomainValidator.unicodeToASCII(authority);
>
> This is supposed to leave the input string along if it cannot convert
> punycode, but it appears to have dropped the final "." when converting
> "www.cnn.com.."
>
> Don't know why that was not noticed before.

Yes, I do - the NET.unicodeToASCII method was only invoked previously
if the host contained non-ASCII characters.
This was to make sure the Java 6 method was not used unless necessary.

So it would not have been used before in the tests.

We need another test for .. after IDN hosts.

I think the 1.4.1 release is OK.

However it will presumably allow IDN hosts with .. at the end.
Not sure that is terribly serious.

>
> On 13 January 2015 at 21:46, sebb <sebbaz@gmail.com> wrote:
>> Yes.
>> Just updated my workspace and ran test and it failed.
>>
>> I've also updated Continuum to 1.6 and that failed too
>>
>> On 13 January 2015 at 21:41, Gary Gregory <garydgregory@gmail.com> wrote:
>>> Is anyone else getting:
>>>
>>> commons-validator
>>> org.apache.commons.validator.routines.UrlValidatorTest
>>> testIsValid(org.apache.commons.validator.routines.UrlValidatorTest)
>>> junit.framework.AssertionFailedError: http://1.2.3.4./test1?action=view
>>> expected:<false> but was:<true>
>>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message