commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gonçalo Marques <goncalodinismarq...@gmail.com>
Subject Re: [collections] COLLECTIONS-551
Date Sat, 31 Jan 2015 18:40:11 GMT
Hi,

I've sent a pull request containing CollectionUtils refactor for review
(COLLECTIONS-551).

Since the next release version is 4.1, I'm wondering if methods that were
deprecated which are tagged with "@since 4.1" shouldn't be promptly removed
from CollectionUtils.


Gonçalo



On Sat, Jan 31, 2015 at 9:20 AM, Gonçalo Marques <
goncalodinismarques@gmail.com> wrote:

> Hi,
>
> Just to let you know I'm working on this.
>
>
> Gonçalo
>
>
> On Thu, Jan 29, 2015 at 9:07 PM, Thomas Neidhart <
> thomas.neidhart@gmail.com> wrote:
>
>> On 01/29/2015 11:57 AM, Gonçalo Marques wrote:
>> > Hello,
>> >
>> > I'm creating this thread in order to discuss issue COLLECTIONS-551.
>> >
>> > I don't know the deprecation policies of the Commons project in detail,
>> but
>> > based on the last comment posted by Thomas on issue COLLECTIONS-550 I
>> > assume that:
>> >
>> > In the next release (4.1):
>> >
>> >  - Methods using Iterables in CollectionUtils should be replicated into
>> > IterableUtils;
>> >
>> >  - Methods in CollectionUtils should be transformed into delegates to
>> the
>> > ones copied to IterableUtils;
>> >
>> >  - Methods in CollectionUtils should be marked as @Depreated.
>> >
>> > In release 5:
>> >
>> >  - Methods in CollectionUtils shall be removed.
>> >
>> >
>> > IMO the Unit Tests related with these methods should be copied into
>> > IterableUtilsTest, but should also be kept in CollectionUtilsTest until
>> > version 5. This way we also guarantee that the delegates in
>> CollectionUtils
>> > don't break in 4.1.
>> >
>> > If this is correct, and if you think I may be useful here, I'm
>> available to
>> > take this issue.
>>
>> Hi Goncalo,
>>
>> yes this is the right way to do it.
>>
>> Would be great if you have some time to work on this.
>>
>> Thomas
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message