commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release Compress 1.10 Based on RC1
Date Fri, 30 Jan 2015 16:48:37 GMT
On Fri, Jan 30, 2015 at 6:06 AM, Stefan Bodewig <bodewig@apache.org> wrote:

> On 2015-01-30, sebb wrote:
>
> > On 30 January 2015 at 08:20, Stefan Bodewig <bodewig@apache.org> wrote:
> >> On 2015-01-28, Benedikt Ritter wrote:
>
> >>> - PROPOSAL.txt is not in the src archives. Should it be?
>
> >> This is only there for historical reasons, I don't even think the other
> >> components still have a file like this.  I've removed it completely.
>
> >>> - there is a typo in the release notes. The first line says "Apache
> >>> Apache Commons Compress"
>
> >> fixed, thanks.
>
> >>> - will clients who extended ZCompressorInputStream be affected by the
> >>> change in it's superclass hierarchy? In other words, is the change to
> >>> ZCompressorInputStream reported by clirr binary compatible with 1.9?
>
> >>> The last one would be a blocker for me. It could be resolved by
> restoring
> >>> the _internal_ package and deprecate it right away.
>
> >> It is reported as not compatible, so yes, we are breaking backwards
> >> compatibility.
>
> > Note that Clirr does not distinguish binary and source compatibility.
> > Breaking binary compatibility is almost never a good idea.
> > However source compatibility may be less important in some cases.
>
> > Which incompatibility is it?
>
> The superclass of ZCompressorInputStream has changed from one we've
> removed with the old __internal__ package to a new one in the now
> supported lzw package.
>

Well, we cannot break BC in a minor release for a public class.  Are we
sure BC breaks?

If we want to make this internal package public, it needs to be copied to
the new location, not moved. Then ZCompressorInputStream would still extend
the internal package.

Gary


>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message