commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [ALL] Commons Parent - include Animal Sniffer?
Date Wed, 14 Jan 2015 01:42:33 GMT
On Tue, Jan 13, 2015 at 6:57 PM, sebb <sebbaz@gmail.com> wrote:

> I've been experimenting with Animal Sniffer in NET as a basic check
> that the code does not try to use method etc which are not present in
> the target Java version.
> [For example, java.net.IDN requires Java 1.6+]
>
> Although the plugin is not fool-proof, it should help to check basic
> errors and allow developers to check code even if they don't have the
> requisite Java version installed.
>
> My question is - should it be included in Commons Parent?
> And if so, should it be enabled by default?
>
> There are various ways of including it:
> - inline. It can then be suppressed by defining animal.sniffer.skip
> - as a profile which is enabled by default, potentially disabled
> manually or by use of a resource file
> - as a profile which is disabled by default, but enabled manually of
> by use of a resource file
>
> The profile options would work a bit like Jacoc/Cobertura, but could
> be enabled by default rather than disabled by default.
>
> WDYT?
>
> I would favour a profile, enabled by default, as this does not add to
> the size of the main body of pom.
>

Sounds reasonable. How long does it take to run for [Net]?

Gary


>
> Note: the build helper plugin can be used to automatically convert
> from the maven.compiler.target syntax (e.g. 1.6) to the Animal Sniffer
> signature syntax (e.g. java16) so there is no need to maintain a
> separate variable.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message