commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: [VALIDATOR] Working on the TLD list (Was: Re: [CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2)
Date Sun, 04 Jan 2015 16:47:49 GMT
2015-01-03 19:32 GMT+01:00 sebb <sebbaz@gmail.com>:

> On 3 January 2015 at 12:34, Benedikt Ritter <britter@apache.org> wrote:
> > Hello Sebb,
> >
> > 2015-01-03 4:35 GMT+01:00 sebb <sebbaz@gmail.com>:
> >
> >> I've made quite a bit of progress.
> >>
> >> However the IANA text file merges all the TLDs into one file - there
> >> is no indication of whether the TLD is a country code or not.
> >> This does not matter for ASCII codes, because they are easy to
> recognise.
> >> Unfortunately it looks as though the only way to distinguish them is
> >> to scan the HTML version of the file and check the Type column.
> >> Not sure it is possible to automate this without a lot of work, so it
> >> may take a bit longer that I had hoped.
> >>
> >
> > No problem. Is there anything we can do to help you?
>
> Turns out that the html format is not all that hard to parse, as it
> appears to be auto generated.
> I have now got it working so it creates separate sorted lists of
> missing general and cc entries with comments.
>
> I will commit the missing entries shortly.
>
> There are still a couple of issues I think it would be good to resolve:
> 1) root, um and yu are not in the txt list. I think they should be
> dropped (VALIDATOR-350)
>

Agreed


> 2) lists are now already sorted, and there are unit tests to check
> this, so I think we could drop the static{} block (VALIDATOR-349)
>

If they are sorted, yes we can drop the static block.


>
> WDYT?
>
> > Benedikt
> >
> >
> >>
> >>
> >> On 2 January 2015 at 14:47, Benedikt Ritter <britter@apache.org> wrote:
> >> > Hi,
> >> >
> >> > this vote in canceled to fix the problems discovered by sebb.
> >> > I will waint until the XN-- entries are added before I roll out a new
> RC.
> >> >
> >> > Thanks!
> >> > Benedikt
> >> >
> >> > 2015-01-01 19:02 GMT+01:00 Benedikt Ritter <britter@apache.org>:
> >> >
> >> >> Hi all,
> >> >>
> >> >> we have fixed the issues which where found in RC1 so I'd like to
> call a
> >> >> new vote to release Apache Commons Validator based on RC2.
> >> >>
> >> >> Changes from RC1:
> >> >> - [VALIDATOR-307] - isValid checks if the given address is only IPV4
> >> >> address and not IPV6
> >> >> - [VALIDATOR-347] - toLowerCase() method is Locale-sensitive and
> should
> >> >> not be used
> >> >> - [VALIDATOR-348] - Update TLD list to latest version (Version
> >> 2014123000)
> >> >> - [VALIDATOR-336] - CUSIPCheckDigit thinks invalid CUSIP is valid.
> >> >> - [VALIDATOR-345] - ISINCheckDigit fails to reject invalid
> (non-numeric)
> >> >> check digits
> >> >> - [VALIDATOR-346] - SedolCheckDigit fails to reject invalid
> >> (non-numeric)
> >> >> check digits
> >> >> - Removed STATUS.html
> >> >> - Added README.md to binary and source distribution
> >> >> - Fixed encoding of source files in build by setting commons.encoding
> >> >> property
> >> >> - Fixed JIRA report to contain the issues of the project
> >> >> - Reverted dependency to commons-beanutils to 1.8.3 since this is the
> >> >> latest JDK 1.4 compatible release
> >> >> - Added JDK requirements to release notes.
> >> >>
> >> >> Validator 1.4.1-RC2 is available for review here:
> >> >>   https://dist.apache.org/repos/dist/dev/commons/validator/ (svn
> >> revision
> >> >> 7629)
> >> >>
> >> >> The tag is here:
> >> >>
> >> >>
> >>
> http://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_1_RC2/
> >> >> (svn revision 1648888)
> >> >>
> >> >> Maven artifacts are here:
> >> >>
> >> >>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1073/commons-validator/commons-validator/1.4.1/
> >> >>
> >> >> Details of changes since 1.4 are in the release notes:
> >> >>
> >> >>
> >>
> https://dist.apache.org/repos/dist/dev/commons/validator/RELEASE-NOTES.txt
> >> >>
> >> >> I have tested this with JDK 1.6, 1.7 and 1.8 using maven 3.2.5.
> >> >>
> >> >> Site (some links my be broken but will be fixed when the site is
> >> deployed):
> >> >>   http://people.apache.org/~britter/validator-1.4.1-RC2/
> >> >>
> >> >> Clirr Report:
> >> >>
> >> http://people.apache.org/~britter/validator-1.4.1-RC2/clirr-report.html
> >> >>
> >> >> RAT Report:
> >> >>
> http://people.apache.org/~britter/validator-1.4.1-RC2/rat-report.html
> >> >>
> >> >> Keys:
> >> >>   https://www.apache.org/dist/commons/KEYS
> >> >>
> >> >> Please review this release candidate and vote.
> >> >> This vote will close no sooner than 72 hours from now, i.e. after
> >> >> 2015/01/04 19:00CET
> >> >>
> >> >> [ ] +1 Release these artifacts
> >> >> [ ] +0 OK, but...
> >> >> [ ] -0 OK, but really should fix...
> >> >> [ ] -1 I oppose this release because...
> >> >>
> >> >> Thanks!
> >> >> Benedikt
> >> >>
> >> >>
> >> >> --
> >> >> http://people.apache.org/~britter/
> >> >> http://www.systemoutprintln.de/
> >> >> http://twitter.com/BenediktRitter
> >> >> http://github.com/britter
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > http://people.apache.org/~britter/
> >> > http://www.systemoutprintln.de/
> >> > http://twitter.com/BenediktRitter
> >> > http://github.com/britter
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message