commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Roberts" <mar...@cs.washington.edu>
Subject RE: [bcel] PLSE changes to BCEL
Date Tue, 27 Jan 2015 04:36:32 GMT
In our opinion, the fix is worse than the disease.  Here are the comments
from our version:

      The following piece of code is new since our 5.2 based version.
   It was added in revision 524610 on 2007-04-01, more information is at:
   http://issues.apache.org/bugzilla/show_bug.cgi?id=39695 (now BCEL-79)
   However, it seems quite wrong to me and I have no idea how it solved the
bug.
   There is no requirement for there to be as many LocalVariableTypeTable
entries
   as there are LocalVariables.  In fact, there will almost always be fewer.
So
   deleting the local variables and reconstructing them from types makes no
sense.
   Was it a bad cut and paste job from above and meant to reconstruct the
types
   table?  Then how did it fix the bug?  More likely, the test case had the
same
   number of vars and types.  If so, the correct code would seem to be only
modify
   those local vars that have a matching type.  I cannot figure out what was
intended
   so I'm just going to comment the whole thing out.   (markro)

To repeat - constructing the local variables from the local variable types
is totally bogus.   I have no idea how that fixed the original problem but
it is clearly incorrect.

Mark

> -----Original Message-----
> From: Emmanuel Bourg [mailto:emmanuel.bourg@gmail.com] On 
> Behalf Of Emmanuel Bourg
>
> Isn't BCEL-79 already fixed?
> 
> 

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message