commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [compress] Preparations for 1.10
Date Sat, 24 Jan 2015 12:18:52 GMT
On 2015-01-23, Emmanuel Bourg wrote:

> Le 22/01/2015 17:30, Stefan Bodewig a écrit :

>> Please have a look and identify stuff that looks as if I'd have to
>> reroll a new RC should it come to a vote with the current code base.

> I reviewed the API changes, here are my comments:

> - PasswordRequiredException: the exception is in the sevenz package, do
> we want to move it elsewhere so it can be used later for other formats
> like zip (if that makes sense).

Moved to a new exceptions package.

> - BitInputStream: why not using a long cache instead of an int, like
> BitStream before the refactoring? It might be interesting to do some
> benchmarks and see if it make a difference.

We never needed more than 31 bits, but you are right, I'll try to
experiment a little.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message