commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bernd Eckenfels <e...@zusammenkunft.net>
Subject Re: [ALL] Commons Parent - include Animal Sniffer?
Date Sun, 18 Jan 2015 02:12:50 GMT
Hello,

I have tested CP 37 with the multi module build of VFS as well. It
worked with a Java7 build on windows. (I did not test if it detects
wrong signatures, only that the build passes).

I also commited the osgi bundle-plugin property I was talking about,
from my POV it would be good if we can release it (both).

The following changes are pending (note I changed the version selection
comment for animal sniffer a bit)

Version 37:

- Update org.apache:apache 15 to 16 (nop for Commons,
  maven-compiler-plugin already contained source/target)
- Adjust Maven prerequisite 3.0 -> 3.0.1 as required by Findbugs
- Update Maven Project Info Reports Plugin : 2.7 => 2.8
- merged maven-3 profile into main body (Maven 2 is no longer supported)
- added Animal Sniffer plugin in profile "animal-sniffer". This is
  active by default.
  The current version of the plugin (1.13) requires Java 7 to report
  API violations.
  The default version is set to 1.11 which works with Java 5 unless
  jdk7-plugin-fix-version is detected.
- renamed the profile jdk7-findbugs to jdk7-plugin-fix-version
- OSGI bundle-plugin allows commons.osgi.excludeDependencies to be
  configured
  (default is true for compatibility with older versions, it excludes
  all dependencies and makes
  the plugin skip most of its work around attributing packages
  correctly)


Gruss
Bernd


 Am Sat, 17 Jan 2015 22:13:20 +0000
schrieb sebb <sebbaz@gmail.com>:

> On 17 January 2015 at 19:35, Thomas Neidhart
> <thomas.neidhart@gmail.com> wrote:
> > On 01/14/2015 12:57 AM, sebb wrote:
> >> I've been experimenting with Animal Sniffer in NET as a basic check
> >> that the code does not try to use method etc which are not present
> >> in the target Java version.
> >> [For example, java.net.IDN requires Java 1.6+]
> >>
> >> Although the plugin is not fool-proof, it should help to check
> >> basic errors and allow developers to check code even if they don't
> >> have the requisite Java version installed.
> >>
> >> My question is - should it be included in Commons Parent?
> >> And if so, should it be enabled by default?
> >>
> >> There are various ways of including it:
> >> - inline. It can then be suppressed by defining animal.sniffer.skip
> >> - as a profile which is enabled by default, potentially disabled
> >> manually or by use of a resource file
> >> - as a profile which is disabled by default, but enabled manually
> >> of by use of a resource file
> >>
> >> The profile options would work a bit like Jacoc/Cobertura, but
> >> could be enabled by default rather than disabled by default.
> >>
> >> WDYT?
> >>
> >> I would favour a profile, enabled by default, as this does not add
> >> to the size of the main body of pom.
> >>
> >> Note: the build helper plugin can be used to automatically convert
> >> from the maven.compiler.target syntax (e.g. 1.6) to the Animal
> >> Sniffer signature syntax (e.g. java16) so there is no need to
> >> maintain a separate variable.
> >
> > I have tested the latest parent 37-SNAPSHOT with the animal-sniffer
> > plugin on email using OpenJDK 1.7 and it worked fine.
> >
> > Thanks!
> 
> Great, thanks for testing it.
> 
> > Thomas
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message