commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: svn commit: r1645679 - /commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/TestBean.java
Date Wed, 17 Dec 2014 10:48:00 GMT
2014-12-16 21:43 GMT+01:00 sebb <sebbaz@gmail.com>:
>
> On 16 December 2014 at 08:49, Benedikt Ritter <britter@apache.org> wrote:
> > 2014-12-15 16:54 GMT+01:00 <sebb@apache.org>:
> >>
> >> Author: sebb
> >> Date: Mon Dec 15 15:54:38 2014
> >> New Revision: 1645679
> >>
> >> URL: http://svn.apache.org/r1645679
> >> Log:
> >> Unused
> >>
> >> Modified:
> >>
> >>
> commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/TestBean.java
> >>
> >> Modified:
> >>
> commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/TestBean.java
> >> URL:
> >>
> http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/TestBean.java?rev=1645679&r1=1645678&r2=1645679&view=diff
> >>
> >>
> ==============================================================================
> >> ---
> >>
> commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/TestBean.java
> >> (original)
> >> +++
> >>
> commons/proper/dbutils/trunk/src/test/java/org/apache/commons/dbutils/TestBean.java
> >> Mon Dec 15 15:54:38 2014
> >> @@ -16,8 +16,6 @@
> >>   */
> >>  package org.apache.commons.dbutils;
> >>
> >> -import java.sql.Timestamp;
> >> -
> >>  /**
> >>   * A bean to use in testing toBean() and toBeanList().
> >>   */
> >> @@ -39,7 +37,7 @@ public class TestBean {
> >>
> >>      private Integer integerTest = Integer.valueOf(0);
> >>
> >> -    private Timestamp timestamp = null;
> >> +    // UNUSED private Timestamp timestamp = null;
> >>
> >
> > Why can't we drop the line completely?
> >
>
> I was not sure if it was part of an attempt to write another unit
> test; I hoped it might remind someone.
>
>
I'd rather drop the line. If anybody needs it for a test he is planning to
implement, he can add it again.


> >>
> >>      private String doNotSet = "not set";
> >>
> >>
> >>
> >>
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message