commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [VOTE] Release Commons Pool 2.3 based on RC2
Date Sat, 27 Dec 2014 20:36:48 GMT
On 12/27/14 12:39 PM, Oliver Heger wrote:
> When building on Windows 7 with Java 1.6 I got a test failure:
>
> Results :
>
> Failed tests:
>   TestGenericObjectPool.testBorrowObjectFairness:2034 Thread 1 failed:
> java.lang
> .Throwable: Expected: 1 found: 2
>
> Tests run: 262, Failures: 1, Errors: 0, Skipped: 0
>
> I guess, this is one of the problematic test cases reported for RC1.

No, but this is another test that can fail due to clock resolution. 
It is not new in this release and there is a comment in the test
code indicating that it can sometimes fail.  We should probably fix
the error message to indicate this.  In any case, I don't see this
as a release blocker.

Phil
> However, I did the build on an older laptop which was under high load;
> so this is probably not an issue.
>
> Artifacts and site look good. One minor nit: On the site menu there are
> Javadoc links for a number of releases, but the 2.3 release is missing.

Yes, I will add the new javadoc and fix the links before publishing
the site post-release.
>
> No blockers, so +1

Thanks!

Phil
>
> Oliver
>
> Am 27.12.2014 um 00:54 schrieb Phil Steitz:
>> Changes since RC1:
>> * Made POOL-259 tests less sensitive to system clock resolution
>> * Moved LinkedBlockingDeque original PD license reference from
>> NOTICE to LICENSE
>>
>> Tag: (r1648018)
>> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_3_RC2/
>>
>> Release: (r7602)
>> https://dist.apache.org/repos/dist/dev/commons/pool/
>>
>> Maven:
>> https://repository.apache.org/content/repositories/orgapachecommons-1072
>>
>> Site:
>> http://people.apache.org/~psteitz/pool/pool-2.3-rc2/
>>
>> Release notes:
>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>
>> Votes, please.  This vote will close in 72 hours (29-Dec 23:55 GMT)
>>
>> [ ] +1 Release this
>> [ ] +0 Ok, but...
>> [ ] -0  Really should fix...
>> [ ] -1 We should not release this RC
>>
>> Thanks!
>>
>> Phil
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message