commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: svn commit: r1647869 - in /commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl: TestGenericKeyedObjectPool.java TestGenericObjectPool.java
Date Fri, 26 Dec 2014 17:40:31 GMT
On 12/25/14 11:50 PM, Bernd wrote:
> Currently cant commit or I would fix it myself, the 50ms from comment
> should be removed (twice)
>
>> // Second borrow does not have to wait on create, average should be about
> 50

Good catch.  I will fix this.
>
> Btw: even without the change the tests worked for me on Windows - it does
> increase the test time rather dramatic, maybe 200ms is better here?

OK, I just cut it down to 200ms.  Lets see if others get failures. 
IIRC you can't count on better than 50ms clock resolution on
Windows.  Current code will work as long as the error is no more
than about 100ms.

Thanks for reviewing!

Phil

>
> Greetings
> Bernd
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message