commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1639021 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/utils/BitInputStream.java test/java/org/apache/commons/compress/utils/BitInputStreamTest.java
Date Fri, 14 Nov 2014 02:04:08 GMT
On 12 November 2014 20:40, Emmanuel Bourg <ebourg@apache.org> wrote:
> Le 12/11/2014 21:02, bodewig@apache.org a écrit :
>
>>      public int readBits(final int count) throws IOException {
>> -        if (count < 0 || count > 32) {
>> +        if (count < 0 || count > 31) {
>>              throw new IllegalArgumentException("count must be between 0 and 32");
>>          }
>>          while (bitsCachedSize < count) {
>
> I think the message of the exception has to be updated too.

It's OK if between is interpreted as meaning strictly between, i.e.
not equal to the end points.
But I agree that it is not very clear currently and could be improved.

> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message