commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: svn commit: r1639021 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/utils/BitInputStream.java test/java/org/apache/commons/compress/utils/BitInputStreamTest.java
Date Fri, 14 Nov 2014 05:13:33 GMT
On 2014-11-14, sebb wrote:

> On 12 November 2014 20:40, Emmanuel Bourg <ebourg@apache.org> wrote:
>> Le 12/11/2014 21:02, bodewig@apache.org a écrit :

>>>      public int readBits(final int count) throws IOException {
>>> -        if (count < 0 || count > 32) {
>>>>        if (count < 0 || count > 31) {
>>>              throw new IllegalArgumentException("count must be between 0 and
32");
>>>          }
>>>          while (bitsCachedSize < count) {

>> I think the message of the exception has to be updated too.

> It's OK if between is interpreted as meaning strictly between, i.e.
> not equal to the end points.
> But I agree that it is not very clear currently and could be improved.

At least it now says 31 again

http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/utils/BitInputStream.java?r1=1639351&r2=1639350&pathrev=1639351

but both of you are correct, it is less than clear, I'll try a better
message.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message