commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Damjan Jovanovic <dam...@apache.org>
Subject Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?
Date Thu, 23 Oct 2014 17:56:34 GMT
On Thu, Oct 23, 2014 at 2:38 PM, Emmanuel Bourg <ebourg@apache.org> wrote:
> Le 23/10/2014 06:42, Damjan Jovanovic a écrit :
>
>> I've been hoping to steal commons-compress's cleaner and faster LZW
>> decompressor, and use it in commons-imaging for TIFF and GIF files,
>> and I've finally managed to make a patch to that effect.
>
> That's great to be able to share the code, thank you for looking at this.
>
>> This requires moving LZWInputStream to a
>> org.apache.commons.compress.compressors.lzw package and making it
>> public. Any objections to this?
>
> I have no objection, but we may want to discuss if BitInputStream should
> belong to this package.

An argument could be made for commons-io, it could be merged with
zip's BitStream, or made package-private.

I am also going to re-examine the 4 LZW implementations and see if
they can be structured better before committing.

>> Also imaging would have to depend on a SNAPSHOT of compress to be able
>> to import LZWInputStream, at least until the next release. Which is
>> when?
>
> When someone wants to release it :)
>
>> I am attaching patches in case anyone wants to have a look, but I can
>> commit them myself if there are no objections.
>
> It looks good to me. There are just some tabs in BitInputStream and an
> import sun.net.www.content.image.gif in GifImageParser.

Thank you, nice catch. I had tabs everywhere... fixed now :).

Damjan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message