commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?
Date Thu, 23 Oct 2014 15:20:43 GMT
On Thu, Oct 23, 2014 at 8:38 AM, Emmanuel Bourg <ebourg@apache.org> wrote:

> Le 23/10/2014 06:42, Damjan Jovanovic a écrit :
>
> > I've been hoping to steal commons-compress's cleaner and faster LZW
> > decompressor, and use it in commons-imaging for TIFF and GIF files,
> > and I've finally managed to make a patch to that effect.
>
> That's great to be able to share the code, thank you for looking at this.
>
> > This requires moving LZWInputStream to a
> > org.apache.commons.compress.compressors.lzw package and making it
> > public. Any objections to this?
>
> I have no objection, but we may want to discuss if BitInputStream should
> belong to this package.
>
> > Also imaging would have to depend on a SNAPSHOT of compress to be able
> > to import LZWInputStream, at least until the next release. Which is
> > when?
>
> When someone wants to release it :)
>
> > I am attaching patches in case anyone wants to have a look, but I can
> > commit them myself if there are no objections.
>
> It looks good to me. There are just some tabs in BitInputStream and an
> import sun.net.www.content.image.gif in GifImageParser.
>

Are you sure about the tabs in BitInputStream? I do not see them... weird.

Gary

>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message