commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luc Maisonobe <...@spaceroots.org>
Subject Re: [GitHub] commons-math pull request: Updated the example documentation for t...
Date Fri, 03 Oct 2014 11:46:39 GMT
Le 02/10/2014 17:51, Ole Ersoy a écrit :
> Hello Luc, Gilles, and Benedikt,
> 
> I'm here :).  From my limited github experience, I do think most
> contributors do their communication directly through github.  I've seen
> a lot of projects use issues for discussion.  I personally like this,
> because it makes it easy to get up to speed on design decisions and
> project history.
> 
> Thanks for letting me know about the differences.  I'll create a new
> fork for any future updates.  I'm surprised that there are differences
> because I did the fork very recently and only made one small change in
> vi before performing the push and pull request.  I only changed that one
> file.

The reason there is a difference is that the GitHub mirror was based on
an early git mirror when our main repository was subversion. We have
switched to Git only a few weeks ago, and the official original git
repository has been recreated from the subversion history, not from the
other git mirror. This means that the commits have been recreated when
the migration was done, and the hashed are different, despite the
content of each commit is the same. See
<https://issues.apache.org/jira/browse/INFRA-8419>.

best regards,
Luc

> 
> Cheers,
> - Ole
> 
> On 10/02/2014 05:03 AM, Gilles wrote:
>> On Thu, 2 Oct 2014 11:48:19 +0200, Benedikt Ritter wrote:
>>> Hi Luc,
>>>
>>> this emails are outgenerated when a PR is created at github, so I
>>> wouldn't
>>> expect the contributor to be subscribed to the list. It's probably
>>> better
>>> to comment on the PR at github.
>>
>> Sorry to intervene; but why is it better to bypass this list?
>> Isn't it expected that a contibutor is subscribed to the project's ML,
>> and not only to a forum built around one of the development tools?
>>
>> Best regards,
>> Gilles
>>
>>>
>>> Benedikt
>>>
>>> 2014-09-30 9:55 GMT+02:00 luc <luc@spaceroots.org>:
>>>
>>>> Hi Ole,
>>>>
>>>> Le 2014-09-30 02:09, oleersoy a écrit :
>>>>
>>>>> GitHub user oleersoy opened a pull request:
>>>>>
>>>>>     https://github.com/apache/commons-math/pull/4
>>>>>
>>>>>     Updated the example documentation for the GaussianCurveFitte
>>>>>
>>>>>
>>>>>
>>>>> You can merge this pull request into a Git repository by running:
>>>>>
>>>>>     $ git pull https://github.com/oleersoy/commons-math trunk
>>>>>
>>>>> Alternatively you can review and apply these changes as the patch at:
>>>>>
>>>>>     https://github.com/apache/commons-math/pull/4.patch
>>>>>
>>>>> To close this pull request, make a commit to your master/trunk branch
>>>>> with (at least) the following in the commit message:
>>>>>
>>>>>     This closes #4
>>>>>
>>>>
>>>>
>>>> I have reviewed and committed the patch.
>>>>
>>>> Beware that your GitHub repository seem to have a lot of differences
>>>> from
>>>> our
>>>> Apache repository. When I atempted a simple "git pull", there were a
>>>> lot
>>>> of conflicts.
>>>>
>>>> I did not investigate, but it may be due to the fact we created a
>>>> new Git
>>>> repository when we
>>>> switched from svn a few days ago, so the official commit hashes are
>>>> most
>>>> probably different from
>>>> yours, despite the content is the same. I would suggest you to clone
>>>> our
>>>> base repository again,
>>>> so you share the same history. This way, you can update your version
>>>> easily.
>>>>
>>>> best regards,
>>>> Luc
>>>>
>>>>
>>>>
>>>>> ----
>>>>> commit 5f7ef4d1ba971086b5e892654175478b7e30917f
>>>>> Author: Ole <ole.ersoy@gmail.com>
>>>>> Date:   2014-09-29T23:56:41Z
>>>>>
>>>>>     Updated the example documentation for the GaussianCurveFitte
>>>>>
>>>>> ----
>>>>>
>>>>>
>>>>> ---
>>>>> If your project is set up for it, you can reply to this email and have
>>>>> your
>>>>> reply appear on GitHub as well. If your project does not have this
>>>>> feature
>>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>>> please
>>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>>>> ticket
>>>>> with INFRA.
>>>>> ---
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message