commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Bourg <ebo...@apache.org>
Subject Re: svn commit: r1628409 - in /commons/proper/bcel/trunk/src: changes/changes.xml main/java/org/apache/bcel/util/ClassLoaderRepository.java
Date Tue, 30 Sep 2014 12:10:40 GMT
Le 30/09/2014 14:08, ggregory@apache.org a écrit :

> Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassLoaderRepository.java
> URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassLoaderRepository.java?rev=1628409&r1=1628408&r2=1628409&view=diff
> ==============================================================================
> --- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassLoaderRepository.java
(original)
> +++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/util/ClassLoaderRepository.java
Tue Sep 30 12:08:10 2014
> @@ -88,10 +88,14 @@ public class ClassLoaderRepository imple
>              if (is == null) {
>                  throw new ClassNotFoundException(className + " not found.");
>              }
> -            ClassParser parser = new ClassParser(is, className);
> -            RC = parser.parse();
> -            storeClass(RC);
> -            return RC;
> +            try {
> +                ClassParser parser = new ClassParser(is, className);
> +                RC = parser.parse();
> +                storeClass(RC);
> +                return RC;
> +            } finally {
> +                is.close();
> +            }
>          } catch (IOException e) {
>              throw new ClassNotFoundException(className + " not found: " + e, e);
>          }
> 
> 

This is not necessary, the stream is already closed at the end of the
parse() method.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message