commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [jcs] logging
Date Sun, 01 Jun 2014 22:47:18 GMT
On 1 June 2014 20:26, Romain Manni-Bucau <rmannibucau@gmail.com> wrote:
> Hi
>
> I have two main point to discuss regarding the logging:
> 1) LogHelper stuffI committed. Idea was to cache isDebugEnabled to get a if
> (boolean) complexity and not go through the logging framework which can
> imply several layers (filter, appender, handler, logger...) for nothing and
> slow down caching (which has more perf constraints than other backends.
> This really depends on the logger you use but we can't suppose it is the
> one we benched against. Solutions I see: a) keep LogHelper, b) remove logs
> (some are useless I think), 3) other?

3) Use a more efficient logger.
and/or
4) For methods that have multiple debug logs, cache the isDebugEnabled
setting locally.

> 2) logger api used. ATM we use [logging] but it will surely be an issue for
> TomEE when integrated ([logging] is the less integrated framework -
> compared to JUL or SLF4J where we don't have the choice at all) and I think
> we'd be happy to remove it from the container to let it be application
> oriented if we can. Any idea to make it hurtless? This doesn't urge and
> doesn't block anything but if someone has an awesome idea it would be
> welcomed ;)

That really belongs in a separate thread.

>
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message