Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF91B1141C for ; Sat, 3 May 2014 02:12:34 +0000 (UTC) Received: (qmail 12191 invoked by uid 500); 3 May 2014 02:12:25 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 12084 invoked by uid 500); 3 May 2014 02:12:25 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 12076 invoked by uid 99); 3 May 2014 02:12:25 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 May 2014 02:12:25 +0000 X-ASF-Spam-Status: No, hits=0.3 required=5.0 tests=FREEMAIL_REPLY,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates 74.125.82.173 as permitted sender) Received: from [74.125.82.173] (HELO mail-we0-f173.google.com) (74.125.82.173) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 May 2014 02:12:21 +0000 Received: by mail-we0-f173.google.com with SMTP id w61so5247750wes.18 for ; Fri, 02 May 2014 19:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=5nbrZO7XZUUvWXw4Vsu9GE6YIexPfsBfvIXS7ULimKQ=; b=LP3hodzVyhej/zlOpQDr3LWKCIf5CtNQvcoxk0cSE0IjBH7aZkFbF3ljRvs1jWqGQH apHy1ShgbPcjtneNETKkMkVrvMFJARW4FauI93wnnnl66AEEq1GGWMpsCnFepHqiK2MH 2IadKXNKsbDoGUBAapTy1hIwDONr0x1T1y1F4w2pAwPj0eoD4kFXXFohlyn8FUCgbe6X DRgTj4FKQIP990dI0HYQ5uK7DKzibV7+1JNg2etApFI39d4n5TljXTUyjMDPJzvCR+Oz 8TnQhtkM0ZjmU3RL/VeM3k0YIJB+0i53HAELJm69xZwHmIw9pFLpeiFG7g234RgjUJts CUog== MIME-Version: 1.0 X-Received: by 10.180.198.109 with SMTP id jb13mr5463980wic.59.1399083120326; Fri, 02 May 2014 19:12:00 -0700 (PDT) Received: by 10.194.9.98 with HTTP; Fri, 2 May 2014 19:12:00 -0700 (PDT) In-Reply-To: References: Date: Sat, 3 May 2014 03:12:00 +0100 Message-ID: Subject: Re: [SANDBOX][BEANUTILS2] Changing code style From: sebb To: Commons Developers List Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org +1 I don't like the curly brace on new line rule as it wastes vertical space ! On 2 May 2014 14:57, Gary Gregory wrote: > +1 > > Gary > > > On Fri, May 2, 2014 at 6:53 AM, Benedikt Ritter wrote: > >> Hi all, >> >> BeanUtils2 uses the maven code style rules. Every now and then I have to >> reject patches because they don't follow these conventions. I'd like to >> change the formatting rules to a more standard rule set for the following >> reasons: >> >> - maven style is very verbose, since it uses a lot of spaces and curly >> braces have to be placed on new lines >> - a great majority of our components uses the Sun/Eclipse formatting with >> spaces >> - Setting up IDEs like IntelliJ or Eclipse is easier with the Sun/Eclipse >> style, because the only thing you have to change is the tab policy. Using >> the maven style implies that one has to import the rule set. >> >> If no one objects, I'll reformat the source code and update the check style >> rules. >> >> Regards, >> Benedikt >> >> >> -- >> http://people.apache.org/~britter/ >> http://www.systemoutprintln.de/ >> http://twitter.com/BenediktRitter >> http://github.com/britter >> > > > > -- > E-Mail: garydgregory@gmail.com | ggregory@apache.org > Java Persistence with Hibernate, Second Edition > JUnit in Action, Second Edition > Spring Batch in Action > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org