commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From triceo <...@git.apache.org>
Subject [GitHub] commons-io pull request: Makes Tailer use ScheduledExecutorService...
Date Sat, 17 May 2014 15:20:50 GMT
GitHub user triceo opened a pull request:

    https://github.com/apache/commons-io/pull/2

    Makes Tailer use ScheduledExecutorService from Java 5

    This has multiple benefits:
    - it provides periodic runs of the read operations without needing to
    invoke Thread.sleep().
    - it removes any looping from the run() method, making for cleaner code.
    - generally brings Tailer closer to what modern Java looks like.
    
    No public API changes have been made. All tests are passing without
    modifications.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/triceo/commons-io tailer-wait

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-io/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2
    
----
commit e3a55a98e44533846625682ed9ad27d28c1cc3c2
Author: Lukáš Petrovický <lpetrovi@redhat.com>
Date:   2014-05-17T15:17:53Z

    Makes Tailer use ScheduledExecutorService from Java 5
    
    This has multiple benefits:
    - it provides periodic runs of the read operations without needing to
    invoke Thread.sleep().
    - it removes any looping from the run() method, making for cleaner code.
    - generally brings Tailer closer to what modern Java looks like.
    
    No public API changes have been made. All tests are passing without
    modifications.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message