commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1591602 - in /commons/proper/collections/trunk/src: changes/ main/java/org/apache/commons/collections4/
Date Thu, 01 May 2014 13:39:59 GMT
On 1 May 2014 14:21, Thomas Neidhart <thomas.neidhart@gmail.com> wrote:
> On 05/01/2014 03:03 PM, sebb wrote:
>> On 1 May 2014 12:05,  <tn@apache.org> wrote:
>>> Author: tn
>>> Date: Thu May  1 11:04:59 2014
>>> New Revision: 1591602
>>>
>>> URL: http://svn.apache.org/r1591602
>>> Log:
>>> [COLLECTIONS-519] Constructors of *Utils classes are now protected to allow sub-classing.
Thanks to Radoslav Paskalev, Daniel Feist.
>>
>> -1
>>
>> I don't think this is a good idea.
>>
>> See my comments on the JIRA issue.
>
> I consider this to be a compromise considering the fact that previously
> the util classes all had a public constructor.
>
> So when people are migrating from 3.2.1 to 4.0, they have some troubles.
> To ease the migration I thought that making it protected is safe:
>
>  * it can not be instantiated

Surely it is now instantiable via a sub-class?

>  * if somebody wants to sub-class: at your own risk, like before
>
> The composition approach is the right way to go, and I would personally
> never do something like the issue originator.

The problem we have is that if 4.1 now allows sub-classing, how can we
ever drop it?

We need to grab the opportunity of 4.x to fix all these bad coding practises.

Conversion to 4.x will amyway require some effort on the part of users.
Let's not spoil the API for all for the sake of a few.

> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message