commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luc Maisonobe <...@spaceroots.org>
Subject Re: [VOTE] Release DBCP 2.0.1 based on RC2
Date Sat, 17 May 2014 13:06:53 GMT
Le 17/05/2014 01:04, Phil Steitz a écrit :
> DBCP 2.0.1 RC2 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/dbcp (r5371)
> 
> Maven artifacts are here:
>   https://repository.apache.org/content/repositories/orgapachecommons-1030/
> 
> Details of changes since 2.0 are in the release notes:
>   https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt
> 
> The tag is here:
>    http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_2_0_1_RC2 (r1595381)
> 
> Site:
>   http://people.apache.org/~psteitz/dbcp/dbcp-2.0.1/
>   (Broken links to Javadoc versions expected)
> 
> Clirr Report:
>   http://people.apache.org/~psteitz/dbcp/dbcp-2.0.1/clirr-report.html
> 
> RAT:
>   http://people.apache.org/~psteitz/dbcp/dbcp-2.0.1/rat-report.html
> 
>   Please review the release candidate and vote.
>   This vote will close no sooner that 72 hours from now
> 
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [X] -0 OK, but really should fix...

A few image files (jpeg and xcf) seem to have been corrupted in both the
source tar.gz and source zip. The corruption is different in both
archives, and they are different to the files retrieved from subversion.

Perhaps a line-ending conversion?

The files are:

static_structure_dia.gif
dbcp-logo-white.xcf
dbcp-logo-blue.jpg
dbcp-logo-white.png
AbandonedObjectPool.gif
BasicDataSource.gif
ConnectionFactory.gif
Delegating.gif
PoolingConnection.gif
PoolingDataSource.gif
createDataSource.gif
getConnection.gif
prepareStatement.gif

The java source files from the .tar.gz also seem to have been stripped
of the last newline, so they generate one checkstyle error each. This is
different from what happens when building directly from the subversion tag.


Apart from this, compilation and tests runs fine on both the tag and the
tar.gz sources.

Luc

>   [ ] -1 I oppose this release because...
> 
> Thanks!
> 
> Phil
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message