Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of niall.pemberton@gmail.com
 designates 209.85.212.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1CE28116-4C72-42A4-87B6-D0EF24AE37E4@gmail.com>
References: <ufu3wshyrwogif4nuqlpyaui.1396099546933@email.android.com>
	<1CE28116-4C72-42A4-87B6-D0EF24AE37E4@gmail.com>
Date: Tue, 1 Apr 2014 01:05:30 +0100
Message-ID: 
 <CAPmHmDSaLSvuW2OeZ3QA1=LfwL=UA6ZTNH6eZb3nPXU5DRG-UQ@mail.gmail.com>
Subject: Re: svn commit: r1582981 - in /commons/proper/lang/trunk: build.xml
 pom.xml
From: Niall Pemberton <niall.pemberton@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=089e013d0f481ca67f04f5efed49

--089e013d0f481ca67f04f5efed49
Content-Type: text/plain; charset=ISO-8859-1

I have fixed the JavaDoc issues with JDK 1.8

Niall


On Sat, Mar 29, 2014 at 2:12 PM, Benedikt Ritter <beneritter@gmail.com>wrote:

> Okay, agreed.
>
> I see three options here:
> 1. fix all javadoc errors
> 2. find a way to Set Xdoclint:none only if building with java 8
> 3. accept, that 3.3.2 can not be build with java 8
>
> 1. requires time, since there are a lot of problems. I won't have the time
> to fix all the errors this weekend. Chosing this option means, that 3.3.2
> will be delayed (unless some one else steps in an fixes all the problems)
> 2. I have no idea how to do this...
> 3. this was acceptable for 3.3.1, since Java 8 hasn't been released back
> then. Java 8 has been released now, so 3.3.2 should be buildable with Java
> 8.
>
> Any other options?
>
> Benedikt
>
> P.S.: I'm not at home currently, so I'll revert the commit tomorrow.
>
> Send from my mobile device
>
> > Am 29.03.2014 um 14:25 schrieb Gary Gregory <garydgregory@gmail.com>:
> >
> > -1 as well. This is only a issue on Java 8.
> >
> > Gary
> >
> > -------- Original message --------
> > From: sebb <sebbaz@gmail.com>
> > Date:03/29/2014  08:17  (GMT-05:00)
> > To: Commons Developers List <dev@commons.apache.org>
> > Subject: Re: svn commit: r1582981 - in /commons/proper/lang/trunk:
> build.xml pom.xml
> >
> > -1 because the change causes Continuum to fail with:
> >
> > javadoc: error - invalid flag: -Xdoclint:none
> >
> >
> >> On 29 March 2014 10:43, Benedikt Ritter <britter@apache.org> wrote:
> >> I hope everybody is okay with this.
> >>
> >>
> >> 2014-03-29 11:42 GMT+01:00 <britter@apache.org>:
> >>
> >>> Author: britter
> >>> Date: Sat Mar 29 10:42:01 2014
> >>> New Revision: 1582981
> >>>
> >>> URL: http://svn.apache.org/r1582981
> >>> Log:
> >>> Disable doclint for 3.3.2 release, since I do not have the time to fix
> all
> >>> the JavaDoc errors
> >>>
> >>> Modified:
> >>>      commons/proper/lang/trunk/build.xml
> >>>      commons/proper/lang/trunk/pom.xml
> >>>
> >>> Modified: commons/proper/lang/trunk/build.xml
> >>> URL:
> >>>
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/build.xml?rev=1582981&r1=1582980&r2=1582981&view=diff
> >>>
> >>>
> ==============================================================================
> >>> --- commons/proper/lang/trunk/build.xml (original)
> >>> +++ commons/proper/lang/trunk/build.xml Sat Mar 29 10:42:01 2014
> >>> @@ -122,7 +122,9 @@
> >>>                    bottom="Copyright &amp;copy; 2001-${current.year} -
> >>> Apache Software Foundation"
> >>>                    use="true"
> >>>                    encoding="${compile.encoding}"
> >>> -                 source="${compile.source}">
> >>> +                 source="${compile.source}"
> >>> +                 additionalparam="-Xdoclint:none">
> >>> +                 <!-- Disable Xdoclint, until JavaDoc issues are
> fixed -->
> >>>               <classpath refid="compile.classpath"/>
> >>>               <link href="${jdk.javadoc}"/>
> >>>               <link href="${collections.javadoc}"/>
> >>>
> >>> Modified: commons/proper/lang/trunk/pom.xml
> >>> URL:
> >>>
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/pom.xml?rev=1582981&r1=1582980&r2=1582981&view=diff
> >>>
> >>>
> ==============================================================================
> >>> --- commons/proper/lang/trunk/pom.xml (original)
> >>> +++ commons/proper/lang/trunk/pom.xml Sat Mar 29 10:42:01 2014
> >>> @@ -520,6 +520,9 @@
> >>>       <commons.site.path>lang</commons.site.path>
> >>>       <commons.scmPubUrl>
> >>>
> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-lang
> >>> </commons.scmPubUrl>
> >>>
> >>>
> <commons.scmPubCheckoutDirectory>site-content</commons.scmPubCheckoutDirectory>
> >>> +
> >>> +    <!-- Disable Xdoclint, until JavaDoc issues are fixed -->
> >>> +    <additionalparam>-Xdoclint:none</additionalparam>
> >>>     </properties>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>
> >>
> >> --
> >> http://people.apache.org/~britter/
> >> http://www.systemoutprintln.de/
> >> http://twitter.com/BenediktRitter
> >> http://github.com/britter
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

--089e013d0f481ca67f04f5efed49--