commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <benerit...@gmail.com>
Subject Re: [CSV] [CSV-110] Making CSVParser.nextRecord()
Date Tue, 08 Apr 2014 12:52:18 GMT
I don't understand why we a) want to have this in 1.0 even though the user already stated that
be doesn't need it in 1.0 and b) want to put this into the parser...
The parser is supposed to parse an abitrary csv input. Following SRP I'd say parsing a single
line is a different thing. What sense does "nextLine" make, when there is only one line I
want to parse? We're trying to bend the parser to do a job, it was originally not intended
for.

Please: let us finish 1.0 and think about this afterwards. We still have two open issues and
I do not feel like we have an idea how to fix those. So why are we discussing this and not
CSV-35 and CSV-58?

Regards,
Benedikt

Send from my mobile device

> Am 08.04.2014 um 14:41 schrieb Gary Gregory <garydgregory@gmail.com>:
> 
> Let's see now, our options for nextRecord() are:
> 
> - public: allows call sites to do
> https://issues.apache.org/jira/browse/CSV-110?focusedCommentId=13961889&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13961889
> - private: allows nothing
> - package private: allows nothing
> - protected and make CSVParser not final: allows
> https://issues.apache.org/jira/browse/CSV-110?focusedCommentId=13962781&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13962781
> 
> Thoughts?
> 
> Yes we could talk about this post-1.0 but:
> - I do not see anyone except me talking about 1.0
> - We have a user story now.
> 
> Thoughts?
> 
> Gary
> 
> 
>> On Tue, Apr 8, 2014 at 8:31 AM, Gary Gregory <garydgregory@gmail.com> wrote:
>> 
>> Hm, now Thomas is suggesting making it protected...
>> 
>> Which is almost like making public but we would not have to officially
>> keep it for BC?
>> 
>> Gary
>> 
>> 
>> On Tue, Apr 8, 2014 at 6:32 AM, Gary Gregory <garydgregory@gmail.com>wrote:
>> 
>>> Ok, I will revert.
>>> 
>>> Gary
>>> 
>>> 
>>> -------- Original message --------
>>> From: Benedikt Ritter
>>> Date:04/08/2014 01:15 (GMT-05:00)
>>> To: Commons Developers List
>>> Subject: Re: [CSV] [CSV-110] Making CSVParser.nextRecord()
>>> 
>>> Hi,
>>> 
>>> I'm in my mobile, so don't expect to much prose from me :)
>>> Making nextRecord() public and the example you provided in the jira look
>>> like a hack to me. Let's finish 1.0 and then think about this feature. It
>>> feels like an Addition to the API that can easily be integrated after 1.0
>>> 
>>> my 2 cents :)
>>> Bene
>>> 
>>> Send from my mobile device
>>> 
>>>> Am 08.04.2014 um 01:06 schrieb Gary Gregory <garydgregory@gmail.com>:
>>>> 
>>>> Ping...
>>>> 
>>>> revert? keep it public?
>>>> 
>>>> Gary
>>>> 
>>>> 
>>>> On Mon, Apr 7, 2014 at 10:47 AM, Gary Gregory <garydgregory@gmail.com
>>>> wrote:
>>>> 
>>>>> Hi All:
>>>>> 
>>>>> For those of you who do not follow JIRA closely. Please take a look at
>>> my
>>>>> reasoning in [CSV-110] for changing the visibility of
>>>>> CSVParser.nextRecord() to public from package private.
>>>>> 
>>>>> Gary
>>>>> 
>>>>> [CSV-110] https://issues.apache.org/jira/browse/CSV-110
>>>>> 
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition<
>>> http://www.manning.com/bauer3/>
>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>> 
>>>> 
>>>> 
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition<
>>> http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>> 
>> 
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> 
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
> 
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message