commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <benerit...@gmail.com>
Subject Re: [jcs] Attempt a 2.0 release
Date Wed, 02 Apr 2014 10:43:14 GMT


Send from my mobile device

> Am 02.04.2014 um 12:19 schrieb sebb <sebbaz@gmail.com>:
> 
>> On 2 April 2014 07:49, Thomas Vandahl <tv@apache.org> wrote:
>>> On 01.04.14 00:25, sebb wrote:
>>> Also, there is a source tree called auxiliary-builds/jdk14.
>>> Since the code now targets 1.6, I assume this is no longer needed?
>> 
>> No. The source tree contains features (such as the JGroups cache) that
>> have not made it (yet) into the main code base. I had a hard time to
>> clean up the code as it was.
>> 
>>> Note that the Maven coordinates have changed and the package names
>>> have changed since 1.3.
>>> 
>>> Effectively 2.0 is a new product, so we should be careful to ensure
>>> that the API is sensible.
>>> For example, no non-private mutable fields (use getter/setter instead).
>>> Prefer immutable classes.
>> 
>> Quite a few of these are performance related.
> 
> Getters are unlikely to cause much if any performance hit compared
> with direct access as a decent compiler will inline them.
> But even if marginally slower they offer major benefits such as
> encapsulation and the possibility to improve thread-safety.
> 
> I doubt there is ever a genuine need to expose a mutable field.

I agree.

> 
>> Please feel free to add
>> some comments to the code where you see fit. I'll check the code and see
>> what I can do.
> 
> OK, will add some TODO comments.
> 
>> Bye, Thomas.
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message