Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.212.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <53027444.1050507@apache.org>
References: <53027444.1050507@apache.org>
Date: Tue, 18 Feb 2014 18:24:27 +0000
Message-ID: 
 <CAOGo0VZftHigmqrAKMpULTMhRb_0FYW0HwUZRM82jjahV_Udrw@mail.gmail.com>
Subject: Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

On 17 February 2014 20:42, Mark Thomas <markt@apache.org> wrote:
> 2.2 fixes a few bugs and adds a new testOnCreate() feature that is
> required by DBCP 2.
>
>
> The Pool 2.2 RC1 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/pool/ (r4424)

Sigs and hashes OK.
Source archive agrees with SVN tag apart from as noted below

> Maven artifacts are here:
>   https://repository.apache.org/content/repositories/orgapachecommons-1008
>
> Details of changes since 2.1 are in the release notes and changelog:
>   https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>   http://people.apache.org/~markt/dev/pool-2.2-RC1-site/changes-report.html
>
>  The tag is here:
>   http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_2_RC1/
>   (r 1569090)

Some shell scripts and download_pool.cgi have SVN eol=native.
Any objections if I change these to LF in trunk?

The shell scripts are missing from the source release - I assume that
is intentional?

However, 3 source files in SVN doc/ folder are missing from the source release.
I don't think that should be the case.

The doap file is also not in the source release; that is to be expected.

>  Site:
>   http://people.apache.org/~markt/dev/pool-2.2-RC1-site
>   (Broken links to Javadoc versions expected)

The Clirr report shows two errors.
These are due to updating the interfaces
GenericKeyedObjectPoolMXBean
and
GenericObjectPoolMXBean

The Javadoc for these interfaces states that they are subject to
change between major releases.
However this is a minor release.

The Clirr errors need to be explained in the Release Notes.
Do they have an impact on user code?
If not, why not?

@since 2.2 markers are present where relevant.

>  KEYS:
>   http://www.apache.org/dist/commons/KEYS
>
>   Please review the release candidate and vote.
>   This vote will close no sooner than 72 hours from now
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>
> Cheers,
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org