Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of thomas.neidhart@gmail.com
 designates 209.85.216.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <64280e22250e84264523f3bbcb6f7bc5@smtp.spaceroots.org>
References: <64280e22250e84264523f3bbcb6f7bc5@smtp.spaceroots.org>
Date: Thu, 20 Feb 2014 11:06:39 +0100
Message-ID: 
 <CAJSjvwt5ux6CgkWA73iZduHFZ611QR2bot02xb226b+OxWH6zg@mail.gmail.com>
Subject: Re: [math] refactoring least squares
From: Thomas Neidhart <thomas.neidhart@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=047d7b66f74b557aa704f2d3a9bc

--047d7b66f74b557aa704f2d3a9bc
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Feb 20, 2014 at 10:05 AM, luc <luc@spaceroots.org> wrote:

> Hi all,
>
> I am looking more precisely at the least squares package and have a few
> adjustments to propose.
>
> The Evaluation interface declares a computeValue and a computeJacobian
> method among others.
> However, it seems the implementations are really simply built with the
> precomputed values and
> just return them. The other compute methods (for covariances for instance)
> do really compute
> something based on the stored Jacobian or value.
>
> Wouldn't it be more clear to use "getValue" and "getJacobian" for these
> two methods and keep
> "compute" for the other ones?
>
> Another point is binding value and Jacobian together in a single object. I
> personally think it
> is a good thing, but if I remember well, some users explicitly asked for
> separating them to save
> some computation. I'm not sure about this, though, so I would like to have
> some advices.
>
> Last point is OptimizationProblem. Should this interface been in fitting
> or in a more general
> package, and in this case which one (optim, util)?
>

I had the same thought, I think it would better fit in optim (considering
that we do not remove the package completely in 4.0 but rather rework it
with the new API).

Thomas

--047d7b66f74b557aa704f2d3a9bc--