Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
MIME-Version: 1.0
In-Reply-To: <53039A3C.70807@apache.org>
References: <53027444.1050507@apache.org>
	<CACZkXPzp5Q+=Xa+UPUS33vMqvUVK_Ps7rs3VBWQS+ysOKdrZfA@mail.gmail.com>
	<53032358.9060007@apache.org>
	<CACZkXPwoEM2PhB0gsi64aX9BikjEQjM=TR0vrgsnZb_OZe_e0Q@mail.gmail.com>
	<53038DC4.9040009@apache.org>
	<CACZkXPwFL1b8CG63gKaGje_=hUt_nFnh98Wjcwtu1aSN8ceDKQ@mail.gmail.com>
	<53039A3C.70807@apache.org>
Date: Tue, 18 Feb 2014 18:49:35 +0100
Message-ID: 
 <CAB917R+dghe1R873KcBnDvceG+uJSYmyo=Sqyi1bRQcDNB2T+A@mail.gmail.com>
Subject: Re: [VOTE] Release Apache Commons Pool 2.2 RC1 as 2.2
From: Benedikt Ritter <britter@apache.org>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=001a11c37c9239763c04f2b1e583

--001a11c37c9239763c04f2b1e583
Content-Type: text/plain; charset=ISO-8859-1

Hi Mark,

I won't have the time before wednesday evening (CET) before I can review a
RC.

Benedikt


2014-02-18 18:37 GMT+01:00 Mark Thomas <markt@apache.org>:

> On 18/02/2014 17:27, Gary Gregory wrote:
> > On Tue, Feb 18, 2014 at 11:43 AM, Mark Thomas <markt@apache.org> wrote:
> >
> >> On 18/02/2014 16:33, Gary Gregory wrote:
> >>> On Tue, Feb 18, 2014 at 4:09 AM, Mark Thomas <markt@apache.org> wrote:
> >>>
> >>>> On 18/02/2014 05:01, Gary Gregory wrote:
> >>>>> Since you'll reroll the RC to fix the release notes for the version,
> >> you
> >>>>> might has well update to commons-parent 33 to pick up the new skin.
> >>>>
> >>>> Why do I need to reroll the RC to fix the release notes?
> >>>
> >>>
> >>> Because the RN file is part of the release, specifically, the source
> zip,
> >>> which is the primary artifact that the ASF releases.
> >>
> >> What you appear to have missed is that what you were looking at was the
> >> 2.1 release notes not the 2.2 release notes. The 2.1 release notes were
> >> left over in dist/dev from the 2.1 release and as I didn't do an svn up
> >> before I added the 2.2 binaries and source I didn't realise that the
> >> release notes needed to be added to /dist. I fixed that by removing the
> >> 2.1 release notes and adding the 2.2 ones.
> >>
> >>> The tag should reflect what we publish for a given RC. The tag for the
> >> 2.2
> >>> RC will be a copy of the tag for the RC that was voted on and passed.
> >>
> >> The release notes currently in dist/dev are exactly the same as those in
> >> the 2.2 tag.
> >>
> >>> That tag should include the release notes with the label "2.2", not
> >> "2.1".
> >>> Hence the request to have it all in sync. It's not the first time that
> a
> >>> new RC would include a fix for the release notes.
> >>
> >> Did you even look the the release notes in the 2.2 tag? They have the
> >> 2.2 label.
> >>
> >
> > I looked at the link to the RN file. I stand corrected! All else looks
> good.
> >
> > +1
>
> Great. I was thinking of rolling an RC2 anyway to pick up the new skin
> and the tweaks to the index page. I'll give folks a few more hours to
> pick holes in RC1 and then roll RC2.
>
> Mark
>
>
> >
> > Tested with src zip (good sig and md5):
> >
> > Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
> > 11:22:22-0400)
> > Maven home: C:\Java\apache-maven-3.1.1\bin\..
> > Java version: 1.7.0_51, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.7.0_51\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> >
> > Site and reports look good.
> >
> > Gary
> >
> >>
> >>
> >>
> http://svn.apache.org/viewvc/commons/proper/pool/tags/POOL_2_2_RC1/RELEASE-NOTES.txt?view=annotate
> >>
> >> Mark
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

--001a11c37c9239763c04f2b1e583--