commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@gmail.com>
Subject Re: svn commit: r1569584 - /commons/proper/weaver/trunk/pom.xml
Date Wed, 19 Feb 2014 02:12:15 GMT
On Tue, Feb 18, 2014 at 8:04 PM, sebb <sebbaz@gmail.com> wrote:

> On 19 February 2014 01:28, Matt Benson <gudnabrsam@gmail.com> wrote:
> > That wasn't supposed to be a Maven property, but a local property. The
> use
> > of the <local> task above establishes a scoped property that will shadow
> > any preexisting value of the property "parent", but I can choose a
> > different name to avoid this confusion. Thanks for getting involved.
>
> I was trying to fix the remaining Maven 3 warnings so I could see if
> it builds OK.
>
> Apologies if it broke something.
>
> Perhaps Maven 3 is finding variables where it should not, but the
> warning is likely to cause issue later unless the variable is renamed.
>
>
I had missed the warning. In any event, I've renamed the property to
parent.dir so thanks again for catching this.

Matt


> > Matt
> >
> >
> > On Tue, Feb 18, 2014 at 7:16 PM, <sebb@apache.org> wrote:
> >
> >> Author: sebb
> >> Date: Wed Feb 19 01:16:54 2014
> >> New Revision: 1569584
> >>
> >> URL: http://svn.apache.org/r1569584
> >> Log:
> >> ${parent} is deprecated, use ${project.parent} instead
> >>
> >> Modified:
> >>     commons/proper/weaver/trunk/pom.xml
> >>
> >> Modified: commons/proper/weaver/trunk/pom.xml
> >> URL:
> >>
> http://svn.apache.org/viewvc/commons/proper/weaver/trunk/pom.xml?rev=1569584&r1=1569583&r2=1569584&view=diff
> >>
> >>
> ==============================================================================
> >> --- commons/proper/weaver/trunk/pom.xml (original)
> >> +++ commons/proper/weaver/trunk/pom.xml Wed Feb 19 01:16:54 2014
> >> @@ -430,7 +430,7 @@ under the License.
> >>                        <sequential unless:true="${exists}">
> >>                          <local name="parent" />
> >>                          <dirname property="parent" file="@{dir}" />
> >> -                        <step dir="${parent}" name="@{name}"
> >> addto="@{addto}" ws="@{ws}" />
> >> +                        <step dir="${project.parent}" name="@{name}"
> >> addto="@{addto}" ws="@{ws}" />
> >>                        </sequential>
> >>                      </sequential>
> >>                    </sequential>
> >>
> >>
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message