commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1
Date Fri, 21 Feb 2014 04:11:05 GMT
I would also like to see reports for FindBugs and PMD. Also: use
commons-parent 33 to pick up the new skin.

Gary


On Thu, Feb 20, 2014 at 12:33 PM, Mark Struberg <struberg@yahoo.de> wrote:

> +1
>
> >The poms don't include any groupId definitions.
>
> Not needed and sometimes even a source of problems. If you do not need to
> write something than adding it only raises the chance it gets wrong.
>
>
>
> > - The jar artifacts contain LICENSE and NOTICE without the .txt
> extension.
> That's perfectly fine. All my ASF projects look that way.
>
>
> > - There is a bunch of checkstyle errors. For an initial release it
>
> > would be good to start with a clean code base.
> I agree, but that's not a show stopper. Those are only warnings.
>
>
> Regarding the mvn clean discussion: We could 'fix' this by using the
> maven-it-plugin. But that makes many things much more complicated to test
> and debug. Thus this is imo nothing we should address soon and all is fine
> imo.
>
>
> LieGrue,
> strub
>
>
> On Wednesday, 12 February 2014, 23:50, sebb <sebbaz@gmail.com> wrote:
>
> On 12 February 2014 02:20, Matt Benson <mbenson@apache.org> wrote:
> >> I would like to make the inaugural release of the [weaver] component.
> >>
> >> Apache Commons Weaver 1.0 RC1 is available for review at:
> >>  https://dist.apache.org/repos/dist/dev/commons/weaver/ (r4368).
> >>
> >> Maven artifacts are at:
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1007/.
> >>
> >> Tested with Oracle JDKs 6 and 7.
> >>
> >> The Subversion tag is:
> >>
> http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.0_RC1/(r1567477)
> .
> >>
> >> Site:
> >>  http://people.apache.org/~mbenson/commons-weaver-1.0-rc1/index.html
> >>
> >> RAT Report:
> >>
> http://people.apache.org/~mbenson/commons-weaver-1.0-rc1/rat-report.html
> >>
> >
> >I've never seen the AL header in release notes before.
> >Not sure that's necessary (and it makes the notes harder to read).
> >
> >The poms don't include any groupId definitions.
> >Although this will default from the parent, I think it is better to
> >specify the group id.
> >Otherwise it is not clear whether the omission is accidental or
> deliberate.
> >Also if the parent group Id ever changes (or perhaps is removed) the
> >component groupId will change unless the groupId is added at that
> >point.
> >
> >
> >> Keys: https://dist.apache.org/repos/dist/release/commons/KEYS
> >>
> >> Please review the release candidate and vote.
> >>   This vote will close no sooner that 72 hours from now, i.e. after
> 0300UTC
> >> 15-February 2014
> >>
> >>   [ ] +1 Release these artifacts
> >>   [ ] +0 OK, but...
> >>   [ ] -0 OK, but really should fix...
> >>   [ ] -1 I oppose this release because...
> >>
> >>   Thanks!
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> >
> >
> >




-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message