commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: svn commit: r1565833 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Date Sat, 08 Feb 2014 10:38:10 GMT
2014-02-08 Benedikt Ritter <britter@apache.org>:

>
>
>
> 2014-02-07 <ggregory@apache.org>:
>
> Author: ggregory
>> Date: Fri Feb  7 22:21:55 2014
>> New Revision: 1565833
>>
>> URL: http://svn.apache.org/r1565833
>> Log:
>> [LANG-969] StringUtils.toEncodedString(byte[], Charset) needlessly throws
>> exception.
>>
>> Modified:
>>
>> commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
>>
>> Modified:
>> commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java?rev=1565833&r1=1565832&r2=1565833&view=diff
>>
>> ==============================================================================
>> ---
>> commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
>> (original)
>> +++
>> commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
>> Fri Feb  7 22:21:55 2014
>> @@ -7625,7 +7625,7 @@ public class StringUtils {
>>       *            the encoding to use, if null then use the platform
>> default
>>       * @return a new String
>>       * @throws UnsupportedEncodingException
>> -     *             If the named charset is not supported
>> +     *             This exception is never thrown and should not be in
>> the signature, it will be removed in 4.0.
>>
>
> I'd like to add a TODO tag. Are you okay with that?
>

OTOH, we have the ticket... to no need for a TODO tag.


>
>
>>       * @throws NullPointerException
>>       *             if the input is null
>>       * @since 3.2
>>
>>
>>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>



-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message