Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 74.125.82.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAOGo0VYrjHoQuB0GEB+y32pb8qATRBcL_FfPMMgOKazoZO89CQ@mail.gmail.com>
References: 
 <CACZkXPwnvP9s=HuwttecnydNeJeuF6+aZRvm5fRGgPKk1y8kfA@mail.gmail.com>
	<52C45ABF.4030100@gmail.com>
	<CACZkXPwm42tw7_7-n_4nbUYOud8Baou==SkVibAa4DixDXcdwQ@mail.gmail.com>
	<CAOGo0VYrjHoQuB0GEB+y32pb8qATRBcL_FfPMMgOKazoZO89CQ@mail.gmail.com>
Date: Thu, 2 Jan 2014 17:51:13 +0000
Message-ID: 
 <CAOGo0VbKZV0t3YNgSs64ZjZmnXZ0Wu0GA+_6oeU=sOb3rJeWoA@mail.gmail.com>
Subject: Re: [VOTE] Release Commons Exec 1.2-RC1
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

On 2 January 2014 17:31, sebb <sebbaz@gmail.com> wrote:
> On 2 January 2014 17:17, Gary Gregory <garydgregory@gmail.com> wrote:
>> On Wed, Jan 1, 2014 at 1:13 PM, Phil Steitz <phil.steitz@gmail.com> wrote:
>>
>>>
>>> I assume what we are voting on is the tars / zips in the Nexus repo.
>>>
>>
>> Yes.
>>
>>
>>>
>>> I could not get the tests to run on Mac OSX (10.9.1).  The Ant build
>>> fails with
>>>
>>>  [junit] Testcase: testExecute took 0.013 sec
>>>     [junit]     Caused an ERROR
>>>     [junit] Cannot run program
>>> "/Users/psteitz/exec-rc/commons-exec-1.2-src/src/test/scripts/test.sh"
>>> (in directory "."): error=13, Permission denied
>>>     [junit] java.io.IOException: Cannot run program
>>> "/Users/psteitz/exec-rc/commons-exec-1.2-src/src/test/scripts/test.sh"
>>> (in directory "."): error=13, Permission denied
>>>
>>>
>> Sounds like an OS permission issue with executables. Can we use Maven to
>> create the right file permissions for sh files in a tar/zip?
>
> AFAIK zip does not support permissions.
>
> Perhaps the permission should be set up by the Ant script?
> Would also presumably need to be done in Maven.
>
> Has anyone tested on Unix?

Followup: I just did so on people

A checkout of SVN works OK, because the *.sh files have executable perm.

An unpacked Zip works OK, because all files have x perm
The tar.gz does not work ok, becaise no files have x perm
Not sure yet whether that is because the original tar permissions were
wrong or what.

I'll see if I can find out; it would likely be easier to fix the tar
rather than the Ant/Maven tests.

>>
>>>
>>> The maven build hangs on DefaultExecutorTest.  The relevant bit of
>>> the thread dump appears to be:
>>>
>>
>> How long did you let it run? For me the whole Ant build takes 2:39 minutes:
>> BUILD SUCCESSFUL
>> Total time: 2 minutes 39 seconds
>>
>> If I run it from Eclipse, it takes 1 minute but some tests fail, so there
>> must be some context the test needs. I do see a test marked as expected to
>> fail on OpenVMS so maybe OSX falls in the same category. I'm not sure. Any
>> help explaining this is appreciated.
>>
>>
>>> "main" prio=5 tid=0x00007fcbea810000 nid=0x1903 in Object.wait()
>>> [0x000000010db52000]
>>>    java.lang.Thread.State: WAITING (on object monitor)
>>>     at java.lang.Object.wait(Native Method)
>>>     - waiting on <0x00000007d5bb8b98> (a
>>> org.apache.commons.exec.ExecuteWatchdog)
>>>     at java.lang.Object.wait(Object.java:503)
>>>     at
>>>
>>> org.apache.commons.exec.ExecuteWatchdog.ensureStarted(ExecuteWatchdog.java:227)
>>>     at
>>>
>>> org.apache.commons.exec.ExecuteWatchdog.isWatching(ExecuteWatchdog.java:194)
>>>     - locked <0x00000007d5bb8b98> (a
>>> org.apache.commons.exec.ExecuteWatchdog)
>>>     at
>>>
>>> org.apache.commons.exec.DefaultExecutorTest.testExecuteAsyncWithTimelyUserTermination(DefaultExecutorTest.java:219)
>>>
>>> This is with
>>>
>>> Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700)
>>> Java version: 1.7.0_45
>>>
>>> I also noticed that the copyright date in the NOTICE file is still
>>> 2011.  That should be fixed.
>>>
>>
>> I fixed the NOTICE file in SVN and will be in RC2, thank you Phil.
>>
>> Gary
>>
>>>
>>> Phil
>>>
>>>
>>>
>>> On 12/30/13, 7:34 AM, Gary Gregory wrote:
>>> > Hello All:
>>> >
>>> > This is a VOTE to release Commons Exec 1.2-RC1
>>> >
>>> > Feature and fix release. Requires a minimum of Java 1.3.
>>> >
>>> > The Apache Commons Exec team is pleased to announce the Apache
>>> > commons-exec-1.2 release!
>>> >
>>> > Apache Commons Exec is a library to reliably execute external processes
>>> > from within the JVM.
>>> >
>>> > Changes in this version include:
>>> >
>>> > New features:
>>> >
>>> > o Set names for started threads.  Issue: EXEC-55. Thanks to Dominik
>>> > Stadler.
>>> >
>>> > Fixed Bugs:
>>> >
>>> > o Issue: EXEC-68.
>>> >   Watchdog kills process immediately if timeout is too large.
>>> >   Thanks to Joel McCance.
>>> >
>>> > o Issue: EXEC-57.
>>> >   Applied the patch from Nickolay Martinov but the timeout disguises the
>>> > fact that the process might be still running.
>>> >   Therefore added a sanity check in order to throw an exception if the
>>> the
>>> > timeout for join() was exceeded.
>>> >   Thanks to Nickolay Martinov.
>>> >
>>> > o Issue: EXEC-60.
>>> >   Fixed dead lock by calling the timeout observers outside of the
>>> > synchronized block thereby removing on pre-requisite of a deadlock.
>>> >   Also added a test case to demonstrate that this problem is fixed (which
>>> > of course can not guarantee the absence of a dead lock).
>>> >   Thanks to Peter Kofler.
>>> >
>>> > o Issue: EXEC-52.
>>> >   Tests fail on HP-UX, because it uses a different syntax for the ping
>>> > command.
>>> >   Thanks to Nickolay Martinov.
>>> >
>>> > o Issue: EXEC-49.
>>> >   "Write dead end" IOException when using Piped streams
>>> w/PumpStreamHandler.
>>> >   When encountering a PipedOutputStream we will automatically close it to
>>> > avoid the exception.
>>> >   Thanks to Kevin Telford.
>>> >
>>> > o Issue: EXEC-34.
>>> >   Race condition prevent watchdog working using ExecuteStreamHandler.
>>> >   Patch submittd by Kristian Rosenvold.
>>> >   Thanks to Marco Ferrante.
>>> >
>>> > This VOTE is open for at least 72 hours until December 23 2013 at 11:30
>>> PM
>>> > EST.
>>> >
>>> > The files:
>>> >
>>> > https://repository.apache.org/content/repositories/orgapachecommons-031/
>>> >
>>> > The tag:
>>> >
>>> > https://svn.apache.org/repos/asf/commons/proper/exec/tags/1.2-RC1
>>> >
>>> > The site:
>>> >
>>> > https://people.apache.org/~ggregory/commons-exec/1.2-RC1/site/
>>> >
>>> > Links to versions of sites and Javadocs will be live when deployed.
>>> >
>>> > Thank you,
>>> > Gary Gregory
>>> >
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org