commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [LANG] Handling of empty string in StringUtils
Date Mon, 13 Jan 2014 20:07:59 GMT
On Mon, Jan 13, 2014 at 12:45 PM, sebb <sebbaz@gmail.com> wrote:

> What does the Javadoc say?
>

The Javadoc describes the current behavior, which is whacky IMO. This could
be a case where the docs documents the code, even though it does not make
sense.

It sounds dangerous to change it in a minor release.

Gary



>
> On 13 January 2014 17:00, Benedikt Ritter <britter@apache.org> wrote:
> > ping, any thought on this?
> >
> >
> > 2014/1/11 Benedikt Ritter <britter@apache.org>
> >
> >> Hi,
> >>
> >> while looking through the open issues for lang, I came across LANG-823:
> >> StringUtils.split should handle empty strings the same as other content
> >> [1]. The request makes sense to me - the empty string should be handled
> >> like any other content.
> >>
> >> Then I looked into StringUtils to see how other methods handle the empty
> >> string and there are more examples of specific handling of the empty
> >> string. For example the following will return true:
> >>
> >>    StringUtils.containsOnly("", "abc")
> >>
> >> and it gets even more weird, since
> >>
> >>    StringUtils.containsNone("", "abc")
> >>
> >> also returns true! How can the same string a the same time _only_
> contain
> >> "abc" and contain none of "abc"?
> >>
> >> I can not see any reason for this behavior. Why is the empty string
> >> different from any other string content? I'd like to change the
> behavior of
> >> the affected methods, but wanted to get some feedback first.
> >>
> >> Benedikt
> >>
> >> [1] https://issues.apache.org/jira/browse/LANG-823
> >>
> >>
> >> --
> >> http://people.apache.org/~britter/
> >> http://www.systemoutprintln.de/
> >> http://twitter.com/BenediktRitter
> >> http://github.com/britter
> >>
> >
> >
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message