commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: [LANG] Etiquette for clearing warnings
Date Mon, 27 Jan 2014 16:30:55 GMT
Hello Duncan,

most of the warnings are probably my fault ;-) I've switched to IntelliJ
IDEA a while ago and am really happy with it. The only thing it doesn't do
as good as Eclipse are compiler warnings. Please go ahead and fix the
stuff. I know the feeling you get, wenn you look at the project and have
the ugly exclamation mark right next to it :-)

You can fix all warnings in one commit.

Regards,
Benedikt


2014/1/27 Duncan Jones <djones@apache.org>

> Hi,
>
> Currently Eclipse is showing me 20 warnings for the lang code-base,
> mostly unnecessary imports and unnecessary (or missing)
> @SuppressWarnings statements.
>
> Is it generally acceptable to file a commit that attempts to swot a
> few (or all) of these in one go?
>
> And perhaps more importantly, do other people see the same warnings
> about @SuppressWarnings? I know these are compiler-specific, so
> perhaps people not using Eclipse are not seeing these. Eclipse, for
> example, doesn't accept
>
>   @SuppressWarnings( "Deprecation" )
>
> as the same as
>
>   @SuppressWarnings(  "deprecation" )
>
> and flags it as an unsupported annotation.
>
> I don't want to irritate half the team by changing the code base to
> suit my IDE, possibly creating further warnings for their own
> preferred IDE. But equally I tend to try and keep any project
> completely free of errors.
>
> Advice welcome!
>
> Kind regards,
>
> Duncan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message